Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Jul 26, 2021

Release Notes

Portable Zip Download

You can now download portable version directly from the releases page. This is the same as manually enabling portable mode after the installation.

Bug fixes

taooceros and others added 23 commits July 19, 2021 15:51
add some space to the end of the scrollviewer
* save setting after startup

* Revert "save setting after startup"

This reverts commit bb9c7a1.

* Update App.xaml.cs

Save Setting After Startup
@jjw24 jjw24 added the release Release PR which contains the changes going into the upcoming release label Jul 26, 2021
@jjw24 jjw24 self-assigned this Jul 26, 2021
@jjw24
Copy link
Member Author

jjw24 commented Jul 26, 2021

@Flow-Launcher/team lets hold off merging feature PRs and just bug fixes for 1.8.1

@jjw24 jjw24 added this to the 1.8.1 milestone Jul 26, 2021
@taooceros
Copy link
Member

Could you take a look at the CI build fail? I think it is due to winget update (which is not supposed to run at pr CI)

@taooceros
Copy link
Member

APPVEYOR_REPO_BRANCH - build branch. For Pull Request commits it is base branch PR is merging into

from appveyor website

@jjw24
Copy link
Member Author

jjw24 commented Jul 28, 2021

@Flow-Launcher/team let's roll

@Zeroto521
Copy link
Member

Zeroto521 commented Jul 28, 2021

I thought the next step we should keep our eyes on unit test, since v1.7 they're more bugs comes up after new version released.

In my experience, some troubles these tests could easily check out.

Test pipeline should pass before prs are merged. There has some, but not enough.

The coverage report should be gave one.

My work computer still runs old version, only my home computer I would try new version.

@taooceros
Copy link
Member

I thought the next step we should keep our eyes on unit test, since v1.7 they're more bugs comes up after new version released.
My work computer still runs old version, only my home computer I would try new version.

Yeah I agree with you. However, unit tests are not easy to write due to the complex dependency graph in Flow, and writing it is not so fun.
Probably the first step is to list which unit test is still lacking in the unit test project.

@jjw24
Copy link
Member Author

jjw24 commented Jul 28, 2021

I thought the next step we should keep our eyes on unit test, since v1.7 they're more bugs comes up after new version released.

This will have to be an ongoing thing, we can't hold off releases until enough tests have been added.

In my experience, some troubles these tests could easily check out.

Test pipeline should pass before prs are merged. There has some, but not enough.

The coverage report should be gave one.

We have tests for each pipeline run, bare in mind flow is a desktop application that internally does a lot of different things and connects with a bunch of interfaces, on top of this it runs in an user environment that is quite unique for each users, so there will always be edge cases that we don't catch.

My work computer still runs old version, only my home computer I would try new version.

We are very quick to patch things up so I don't see much risks in upgrading, we never had a report of complete meltdown where flow was rendered useless.

Overall the general concensus is yeah we need to add more tests to those critical functionalities, at the same time we need to roll out fixes like this one so the bugs we/users find can be quickly stamped out.

@taooceros can you approve this please

Add Slovak translation for Explorer plugin
@pc223
Copy link
Contributor

pc223 commented Jul 28, 2021

@taooceros Should we add PR #554 as a temporary fix for the delay?

@jjw24
Copy link
Member Author

jjw24 commented Jul 29, 2021

I was testing pr 554 and got a freeze with nothing logged. we will need to investigate a bit more.

@jjw24 jjw24 merged commit 620ed4a into master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Release PR which contains the changes going into the upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants