Fix Windows Index Search service not activated #599
Conversation
|
|
||
| internal async static Task<List<Result>> WindowsIndexSearchAsync(string searchString, string connectionString, | ||
| internal async static Task<List<Result>> WindowsIndexSearchAsync(string searchString, | ||
| Func<CSearchQueryHelper> queryHelper, |
There was a problem hiding this comment.
why not simply accept a CSearchQueryHelper here?
There was a problem hiding this comment.
Well not much of difference at this stage to pass in the actual object or the function. Just thought to keep it consistent with other parameters, and in the future if we do need to test this function we don't need to mock up the object or change it to a function parameter
There was a problem hiding this comment.
Hmm even with the delegate seems that we still need to mock the object for testing🧐.
There was a problem hiding this comment.
Not really, with Explorer's approach you can test each individual function for their behaviour
There was a problem hiding this comment.
I mean we still need to mock a CSearchQueryHelper to test this.
There was a problem hiding this comment.
Creating a connection string calls CSearchManager, that's why I had to change it
There was a problem hiding this comment.
Sorry i didn't notice the message.
I think it would be better to keep the dependency cleaner. This method only requires a connection string, so probably creating it outside and pass that in would be better.
I don't think the c search manager belongs to this method, so why not create it outside the method?
Too much delegate may make the code a bit hard to understand.
There was a problem hiding this comment.
CSearchManager is part of this method call chain, other alternative is to pass in the query helper object, do this instead?
There was a problem hiding this comment.
Yeah I mean so. I just not quite understand the need to pass a delegate here.
Resolves the issue where the Windows Search service required for Windows Index Search in Explorer plugin is turned off by the user intentionally and currently throwing the error report window on every character typed.
To replicate this issue, you need to stop Windows Search service, disable it so it wont be activated by other services, and then type in the search window to trigger Explorer 's Windows Index Search.
Solution:
Users who intentionally stopped the service usually are inclined to use Everything instead.
Close #581