update to ExplorerPathActionkeyword branch

[jjw24]

No description provided.

[taooceros]

Why not use binding instead of a seperated function triggered when checked

[jjw24]

Why not use binding instead of a seperated function triggered when checked

Crossed out?

[taooceros]

Why not use binding instead of a seperated function triggered when checked

Crossed out?

Crossed out because the function require additional checking (but still can be done in binding, but is similarly complex). Let me check whether we can simplify this process.

[taooceros]

hmmm some logic is weird. Give me some time to fix that.

[taooceros]

Do we want these setting be the same? Or they are not supposed to be the same (the same just to use SearchActionkeyword)

[jjw24]

Do we want these setting be the same? Or they are not supposed to be the same (the same just to use SearchActionkeyword)

what settings are you referring to?

[taooceros]

Do we want these setting be the same? Or they are not supposed to be the same (the same just to use SearchActionkeyword)

what settings are you referring to?

The four action keywords.

[jjw24]

same as in using the global action keyword? then yes except for content search which default is doc:

[taooceros]

same as in using the global action keyword? then yes except for content search which default is doc:

Well in my last commit, I make it to be exclusive. I would consider user should use the SearchActionkeyword when they want index search and path search with one actionkeyword, use PathSearchActionkeyword or IndexOnlyActionkeyword when they only wants a specific location.
Maybe there's no need for allowing duplicate actionkeyword, which will increase the complexity of updating actionkeyword.

[jjw24]

same as in using the global action keyword? then yes except for content search which default is doc:

Well in my last commit, I make it to be exclusive. I would consider user should use the SearchActionkeyword when they want index search and path search with one actionkeyword, use PathSearchActionkeyword or IndexOnlyActionkeyword when they only wants a specific location.
Maybe there's no need for allowing duplicate actionkeyword, which will increase the complexity of updating actionkeyword.

Yeah, the changes in this pr is intending to allow search as how it is functioning before, plus those individual action keywords when enabled.

No need to worry about allowing dup action keyword for this, if we going to tackle it better do it in a separate pr.

[jjw24]

Only duplicate action keyword that is allowed is global action keyword

[taooceros]

Only duplicate action keyword that is allowed is global action keyword

yes you are right, because that's handled by Flow's plugin system.

[jjw24]

if this is good to go, shall we merge it into your pr?

[taooceros]

if this is good to go, shall we merge it into your pr?

Sure, I just waiting for your review.