Add specific keyword for path explore in explorer plugin #449

taooceros · 2021-05-22T09:24:25Z

resolve #355

Seperated directory and index search, original main search is still intact.
Allow action keywords (except file content search) to be disabled, reduces query time when not used.
When an action keyword is not used, disable it automatically
When user changes a disabled action keyword, enable it automatically

jjw24 · 2021-05-23T22:05:48Z

.editorconfig

+[*.cs]
+
+# IDE0011: 添加大括号
+csharp_prefer_braces = when_multiline


is this needed?

Sorry I forget to response to this message. I add that because vs is consistently asking me to add brace after if. I don't notice that it will be pushed to the repo. Sorry.

I will be afk for these two days, so I will revise that after tomorrow.

All good, I wasn't sure of this option. I might remove it next time I continue to review this pr, if you haven't done do.

jjw24 · 2021-05-26T10:06:22Z

can we keep the action keyword to trigger both index and path search?

jjw24 · 2021-05-26T10:43:08Z

i am making some enhancements to allow using the original search action keyword or dedicated path and index action keywords. will push up soon.

jjw24 · 2021-05-26T11:32:15Z

this issue should resolve 355 not 292 right?

taooceros · 2021-05-26T11:40:28Z

this issue should resolve 355 not 292 right?

Ah you are right

jjw24 · 2021-05-26T12:00:20Z

were you ever able to successfully implement allowing duplicate action keywords?

taooceros · 2021-05-27T10:36:17Z

were you ever able to successfully implement allowing duplicate action keywords?

I only allow duplicate * keyword, but it is possible to implement duplicate action keywords without #227

taooceros · 2021-05-28T09:52:07Z

Do we want all actionkeyword in Explorer plugin can be the same? Or only Path and Index search, while full-text search will remain distinct?

jjw24 · 2021-05-28T10:00:38Z

Maybe just hold off if you are going to make changes, I have made some new changes but have not pushed up yet. Will do so tomorrow

jjw24 · 2021-05-30T05:23:10Z

@taooceros I think it's better to keep the Search Activation action keyword for the scenario where you can still use one action keyword to search index & path. We can add additional action keywords this way as well so we get the best of both scenarios.

I made the changes in #457, please take a look and let me know what you think, merge if all good.

1. Moving Property match to Settings.cs 2. Use Binding to avoid explicit Function Assign 3. Simplify ActionKeywordMatch

update to ExplorerPathActionkeyword branch

jjw24 · 2021-06-05T04:09:58Z

found an issue with current action keyword binding, to repro- change file content keyword will reveal that the current action keyword is already assigned.

jjw24 · 2021-06-05T05:45:05Z

binding causes cancel to be ineffective too, think we can switch OK to Done and remove Cancel

taooceros · 2021-06-05T05:47:40Z

binding causes cancel to be ineffective too, think we can switch OK to Done and remove Cancel

Yeah if that's OK for you. I think I forget to implement cancel. 😂😖

taooceros · 2021-06-05T10:07:37Z

Oh you mean when the action keyword is global, and disabled, user click done it is supposed to enable the action keyword?

yeah something like that. When user want to enable global, it will return false and show users that this is already assigned, because the old one is equal to the new one.

jjw24 · 2021-06-05T10:08:49Z

Hold on it shouldnt show the message to tell user there is already one assigned in my latest commit, Are you working off that?

jjw24 · 2021-06-05T10:11:02Z

Basically it should behave as- do not update the search keyword if it (global/non global) is already assigned.

taooceros · 2021-06-05T10:12:27Z

Hold on it shouldnt show the message to tell user there is already one assigned in my latest commit, Are you working off that?

Not sure whether I have changed something wrong. Let me take a look on the current commit.

jjw24 · 2021-06-05T10:12:48Z

Additionally, if action keyword is disabled, and user changes action keyword, then enable it automatically.

If action keyword is enabled and user disable it, automatically revert to global

taooceros · 2021-06-05T10:15:16Z

Additionally, if action keyword is disabled, and user changes action keyword, then enable it automatically.

If action keyword is enabled and user disable it, automatically revert to global

Yes, I see these logic and keep them.

There's a logic issue on the last commit. If the IsActionKeywordAssigned return false, it will still close the window, but not to tell user that they are supposed to change some setting that is not allowed. I believe that why you don't discover the issue.

jjw24 · 2021-06-05T10:17:29Z

Additionally, if action keyword is disabled, and user changes action keyword, then enable it automatically.
If action keyword is enabled and user disable it, automatically revert to global

Yes, I see these logic and keep them.

There's a logic issue on the last commit. If the IsActionKeywordAssigned return false, it will still close the window, but not to tell user that they are supposed to change some setting that is not allowed. I believe that why you don't discover the issue.

Yes good pick up lol, I forgot abt that use case.

…etting.xaml 1. It will automatically focus on the textbox 2. Enter will trigger the done button

taooceros · 2021-06-06T03:05:38Z

I finish the editing. Now, ActionKeywordView is linked to setting.actionkeyword, and it will only be trigger when hitting the done button. We can add the Cancel Button back if you want because I use two temp field to store ActionKeyword and Enabled for binding (because I directly linked ActionKeywordView to setting, so using another instance of that won't work for this design).

jjw24 · 2021-06-06T03:49:20Z

let me take it for a spin

We can add the Cancel Button back if you want because I use two temp field to store ActionKeyword and Enabled for binding (because I directly linked ActionKeywordView to setting, so using another instance of that won't work for this design).

I dont really mind not having the cancel button, i think this is more modern design right? the only thing i think worth thinking about is it's not consistent with the rest of the plugins, but i would prefer modern design and put in effort to move the default plugins as well as Flow's interface towards that.

jjw24 · 2021-06-06T04:06:22Z

Getting this error when i change search action keyword to e (which works and triggers) then switch back to global (then nothing works, no results from any plugin displays):

Exception thrown: 'System.Collections.Generic.KeyNotFoundException' in System.Private.CoreLib.dll
Exception thrown: 'System.Reflection.TargetInvocationException' in System.Private.CoreLib.dll
System.Windows.Data Error: 8 : Cannot save value from target back to source. BindingExpression:Path=QueryText; DataItem='MainViewModel' (HashCode=8662426); target element is 'TextBox' (Name='QueryTextBox'); target property is 'Text' (type 'String') KeyNotFoundException:'System.Collections.Generic.KeyNotFoundException: The given key 'e' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Flow.Launcher.ViewModel.MainViewModel.RemoveOldQueryResults(Query query) in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 564
at Flow.Launcher.ViewModel.MainViewModel.QueryResults() in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 471
at Flow.Launcher.ViewModel.MainViewModel.Query() in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 352
at Flow.Launcher.ViewModel.MainViewModel.set_QueryText(String value) in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 270'
The thread 0x2acc has exited with code 0 (0x0).
The thread 0x54b0 has exited with code 0 (0x0).
The thread 0x35c0 has exited with code 0 (0x0).
The thread 0x4770 has exited with code 0 (0x0).

taooceros · 2021-06-06T04:08:54Z

We can add the Cancel Button back if you want because I use two temp field to store ActionKeyword and Enabled for binding (because I directly linked ActionKeywordView to setting, so using another instance of that won't work for this design).

I dont really mind not having the cancel button, i think this is more modern design right? the only thing i think worth thinking about is it's not consistent with the rest of the plugins, but i would prefer modern design and put in effort to move the default plugins as well as Flow's interface towards that.

Well, I am not sure whether not having a cancel button is a more modern design (in fact, what's a more modern design is hard to be argued).

taooceros · 2021-06-06T04:10:08Z

Getting this error when i change search action keyword to e (which works and triggers) then switch back to global (then nothing works, no results from any plugin displays):

Exception thrown: 'System.Collections.Generic.KeyNotFoundException' in System.Private.CoreLib.dll
Exception thrown: 'System.Reflection.TargetInvocationException' in System.Private.CoreLib.dll
System.Windows.Data Error: 8 : Cannot save value from target back to source. BindingExpression:Path=QueryText; DataItem='MainViewModel' (HashCode=8662426); target element is 'TextBox' (Name='QueryTextBox'); target property is 'Text' (type 'String') KeyNotFoundException:'System.Collections.Generic.KeyNotFoundException: The given key 'e' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Flow.Launcher.ViewModel.MainViewModel.RemoveOldQueryResults(Query query) in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 564
at Flow.Launcher.ViewModel.MainViewModel.QueryResults() in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 471
at Flow.Launcher.ViewModel.MainViewModel.Query() in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 352
at Flow.Launcher.ViewModel.MainViewModel.set_QueryText(String value) in C:\Workbench\Git\Flow.Launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 270'
The thread 0x2acc has exited with code 0 (0x0).
The thread 0x54b0 has exited with code 0 (0x0).
The thread 0x35c0 has exited with code 0 (0x0).
The thread 0x4770 has exited with code 0 (0x0).

That seems some concurrency issue? Let me take a check on that.

taooceros · 2021-06-06T04:21:59Z

Do we need this logic? I don't believe we have an increment strategy when updating plugins.

taooceros · 2021-06-06T04:25:07Z

hmmm Let me check for the update logic

taooceros · 2021-06-06T06:12:28Z

I found the issue. When we have a temp query, and change the actionkeyword for a plugin, it will result the dictionary being changed, but this method will access last time actionkeyword to check for removing results. Therefore, it will result the issue. I will fix it soon.

taooceros · 2021-06-06T06:30:20Z

I rethink logic about that. We don't need to make it so complicate. Only if current actionkeyword and lastactionkeyword is null, we need to refresh the view. No need for only removing results for certain plugins because every query results will refresh their plugin results else where (which is not incremental). Removing all will be fine and clear.

jjw24 · 2021-06-13T08:13:36Z

From testing, fixed two minor logic issue with file content search and revert to global when disabled, otherwise 💯 , lets get this merged.

Add specific keyword for path explore in explorer plugin

acba2dd

taooceros requested a review from jjw24 May 22, 2021 09:24

add Chinese translation

972a291

jjw24 reviewed May 23, 2021

View reviewed changes

jjw24 assigned taooceros May 26, 2021

jjw24 added the enhancement New feature or request label May 26, 2021

jjw24 enabled auto-merge May 26, 2021 09:50

remove unexpected editor config

e4a15b4

jjw24 added 4 commits May 29, 2021 20:08

keep search activation, enable and disable path and index search

7e799b5

replace action keyword when updating

e5fbfa2

update action keyword match logic

3bf3afc

remove obsolete key

e9abaf3

option to allow action keywords to be disabled

995cf56

jjw24 added the review in progress Indicates that a review is in progress for this PR label May 31, 2021

taooceros and others added 4 commits June 1, 2021 18:10

Refactor Code

5966ddc

1. Moving Property match to Settings.cs 2. Use Binding to avoid explicit Function Assign 3. Simplify ActionKeywordMatch

Merge pull request #457 from Flow-Launcher/add_explorer_path

9d7ff08

update to ExplorerPathActionkeyword branch

Merge remote-tracking branch 'origin/dev' into ExplorerPathActionkeyword

002c27f

removed obsolete api object, updated search action keyword naming,

f13e24b

Finishing editing logic, and add a few interactive for ActionKeywordS…

7854cf3

…etting.xaml 1. It will automatically focus on the textbox 2. Enter will trigger the done button

Modify logic in RemoveOldQueryResults() MainViewModel.cs

4d501ba

taooceros and others added 5 commits June 6, 2021 14:31

No need for the temp variable

9557d7e

update logic when content search is global

596b5b8

update revert to global wildcard logic

69f5851

remove obsolete settings class

d807b21

clean up

c842a4c

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Jun 13, 2021

jjw24 merged commit ad36f89 into dev Jun 13, 2021

jjw24 approved these changes Jun 13, 2021

View reviewed changes

jjw24 deleted the ExplorerPathActionkeyword branch June 13, 2021 08:16

This was referenced Jun 13, 2021

Release 1.8.0 | Plugin 2.0.0 #363

Merged

dev branch only: Explorer plugin version bump for PR 449 #473

Merged

Uh oh!

Add specific keyword for path explore in explorer plugin #449

Add specific keyword for path explore in explorer plugin #449

Uh oh!

Conversation

taooceros commented May 22, 2021 • edited by jjw24 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 May 23, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 May 25, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 May 25, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros May 25, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 commented May 26, 2021

Uh oh!

jjw24 commented May 26, 2021

Uh oh!

jjw24 commented May 26, 2021

Uh oh!

taooceros commented May 26, 2021

Uh oh!

jjw24 commented May 26, 2021

Uh oh!

taooceros commented May 27, 2021

Uh oh!

taooceros commented May 28, 2021

Uh oh!

jjw24 commented May 28, 2021

Uh oh!

jjw24 commented May 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Jun 5, 2021

Uh oh!

jjw24 commented Jun 5, 2021

Uh oh!

taooceros commented Jun 5, 2021

Uh oh!

taooceros commented Jun 5, 2021

Uh oh!

jjw24 commented Jun 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Jun 5, 2021

Uh oh!

taooceros commented Jun 5, 2021

Uh oh!

jjw24 commented Jun 5, 2021

Uh oh!

taooceros commented Jun 5, 2021

Uh oh!

jjw24 commented Jun 5, 2021

Uh oh!

taooceros commented Jun 6, 2021

Uh oh!

jjw24 commented Jun 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Jun 6, 2021

Uh oh!

taooceros commented Jun 6, 2021

Uh oh!

taooceros commented Jun 6, 2021

Uh oh!

taooceros commented Jun 6, 2021

Uh oh!

taooceros commented Jun 6, 2021

Uh oh!

taooceros commented Jun 6, 2021

taooceros commented May 22, 2021 •

edited by jjw24

Loading

taooceros May 25, 2021 •

edited

Loading

jjw24 commented May 30, 2021 •

edited

Loading

jjw24 commented Jun 5, 2021 •

edited

Loading

jjw24 commented Jun 6, 2021 •

edited

Loading