Skip to content

Conversation

@Jack251970
Copy link
Member

@Jack251970 Jack251970 commented Jun 3, 2025

Use dynamic resource instead of binding for string resources to make sure it can listen to resource changed event

@Jack251970 Jack251970 requested a review from onesounds June 3, 2025 05:58
@Jack251970 Jack251970 enabled auto-merge June 3, 2025 05:58
@Jack251970 Jack251970 added the bug Something isn't working label Jun 3, 2025
@Jack251970 Jack251970 added this to the 1.20.0 milestone Jun 3, 2025
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@gitstream-cm
Copy link

gitstream-cm bot commented Jun 3, 2025

🥷 Code experts: onesounds, Yusyuriv

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY 40 additions & 11 deletions
APR 130 additions & 69 deletions 11 additions & 8 deletions
MAR 43 additions & 62 deletions 44 additions & 20 deletions
FEB 1 additions & 1 deletions
JAN 8 additions & 1 deletions

Knowledge based on git-blame:
onesounds: 62%
Jack251970: 13%

To learn more about /:\ gitStream - Visit our Docs

@gitstream-cm
Copy link

gitstream-cm bot commented Jun 3, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@Jack251970 Jack251970 requested a review from jjw24 June 3, 2025 05:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 3, 2025

📝 Walkthrough

Walkthrough

The change updates the XAML binding for the "AlwaysPreview" card's subtitle in the settings UI. It replaces a data context property binding with a dynamic resource reference, shifting the tooltip text resolution from a ViewModel property to a resource dictionary entry.

Changes

File(s) Change Summary
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml Changed the "AlwaysPreview" card's subtitle binding from ViewModel property to dynamic resource reference.

Possibly related PRs

Suggested labels

kind/ui, kind/i18n, Dev branch only

Poem

A card in the settings, once bound to a string,
Now fetches its words from resources we bring.
With dynamic resolve, the tooltip will show,
In any language, wherever you go!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db97288 and a3b0b2d.

📒 Files selected for processing (1)
  • Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (2)
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (2)

157-157: LGTM! Improves consistency with UI pattern.

This change aligns the Sub property binding with the consistent pattern used throughout the file, where most other cards use {DynamicResource ...} for their subtitle text. This is better for localization and maintainability.


157-157:

✅ Verification successful

Verify that the AlwaysPreviewToolTip resource exists.

Ensure that the AlwaysPreviewToolTip resource key is defined in the appropriate resource dictionary to prevent runtime binding failures.


🏁 Script executed:

#!/bin/bash
# Description: Search for the AlwaysPreviewToolTip resource definition in resource files
# Expected: Find the resource key defined in .xaml or .resx files

echo "Searching for AlwaysPreviewToolTip resource definition..."
rg -A 2 -B 2 "AlwaysPreviewToolTip" --type xml
rg -A 2 -B 2 "AlwaysPreviewToolTip" --type resx

echo -e "\nSearching in XAML resource files..."
fd -e xaml -x grep -l "AlwaysPreviewToolTip" {}

Length of output: 1314


🏁 Script executed:

#!/bin/bash
# Check if AlwaysPreviewToolTip is defined in the default English language resource dictionary
grep -R -n "AlwaysPreviewToolTip" Flow.Launcher/Languages/en.xaml -A 1 -B 1

Length of output: 438


Resource key AlwaysPreviewToolTip confirmed
The AlwaysPreviewToolTip entry is defined on line 109 of Flow.Launcher/Languages/en.xaml. Runtime bindings will succeed—no further changes needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970 Jack251970 merged commit dbba91a into dev Jun 3, 2025
17 checks passed
@Jack251970 Jack251970 deleted the title_binding branch June 3, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants