Skip to content

Conversation

@onesounds
Copy link
Contributor

Two hardcoded texts have been replaced with string resources.

@onesounds onesounds self-assigned this Jun 1, 2025
@onesounds onesounds added 1 min review kind/ui related to UI, icons, themes, etc kind/i18n labels Jun 1, 2025
@github-actions
Copy link

github-actions bot commented Jun 1, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@gitstream-cm
Copy link

gitstream-cm bot commented Jun 1, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 1, 2025

📝 Walkthrough

Walkthrough

A new string resource "advanced" was added to the English language resource file. In the settings pane's About view, hardcoded UI strings for "Advanced" and "Reset" were replaced with dynamic resource references, enabling localization or theming of these elements.

Changes

File(s) Change Summary
Flow.Launcher/Languages/en.xaml Added "advanced" string resource to the English language dictionary.
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml Replaced hardcoded "Advanced" and "Reset" UI text with dynamic resource references.

Suggested labels

kind/ui, enhancement

Suggested reviewers

  • Jack251970

Poem

In the warren where settings abound,
"Advanced" now hops with a localized sound.
No more hardcoded, the strings are set free,
For rabbits and users, more global they'll be!
With "Reset" in tow, dynamic and neat—
This update makes translations a treat! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43227d8 and 6235914.

📒 Files selected for processing (2)
  • Flow.Launcher/Languages/en.xaml (1 hunks)
  • Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml (2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Check Spelling
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml

[warning] 66-66: Spell check warning: userdatapath is not a recognized word. (unrecognized-spelling)

⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (3)
Flow.Launcher/Languages/en.xaml (1)

362-362:

✅ Verification successful

Add new localization key advanced
Good externalization of the "Advanced" label. Ensure this key is also propagated to all other language resource files to avoid missing translations.

Run this script to find any language files missing the key:

Would you like assistance updating those files?


🏁 Script executed:

#!/bin/bash
# List language files under Flow.Launcher/Languages that do NOT contain the 'advanced' key
rg -L '<system:String x:Key="advanced">' -g 'Flow.Launcher/Languages/*.xaml'

Length of output: 171


Localization key ‘advanced’ verified; no missing translations

The advanced key is present in Flow.Launcher/Languages/en.xaml, and there are no other .xaml resource files in Flow.Launcher/Languages that need this key. No further updates are required at this time.

Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml (2)

139-142: Localize the "Advanced" section title
Replaced a hardcoded "Advanced" with {DynamicResource advanced} to support localization and theming. This aligns with the existing pattern for other UI text.


158-160: Localize the "Reset" button content
Switching from a hardcoded "Reset" to {DynamicResource commonReset} reuses the shared resource and maintains consistency across the UI.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@onesounds onesounds merged commit b69a8ee into Flow-Launcher:dev Jun 1, 2025
8 of 9 checks passed
@Jack251970 Jack251970 added Dev branch only An issue or fix for the Dev branch build and removed 1 min review labels Jun 1, 2025
@Jack251970 Jack251970 added this to the 1.20.0 milestone Jun 1, 2025
@gitstream-cm
Copy link

gitstream-cm bot commented Jun 1, 2025

🥷 Code experts: Jack251970

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Yusyuriv have most 🧠 knowledge in the files.

See details

Flow.Launcher/Languages/en.xaml

Activity based on git-commit:

onesounds Jack251970
JUN 1 additions & 0 deletions
MAY 15 additions & 2 deletions 12 additions & 3 deletions
APR 45 additions & 23 deletions 22 additions & 21 deletions
MAR 8 additions & 3 deletions 67 additions & 42 deletions
FEB 15 additions & 9 deletions
JAN 1 additions & 0 deletions

Knowledge based on git-blame:
onesounds: 43%
Yusyuriv: 5%

Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml

Activity based on git-commit:

onesounds Jack251970
JUN 2 additions & 2 deletions
MAY
APR 43 additions & 13 deletions 11 additions & 2 deletions
MAR 9 additions & 1 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 61%
Yusyuriv: 33%

To learn more about /:\ gitStream - Visit our Docs

@jjw24 jjw24 added bug Something isn't working and removed Dev branch only An issue or fix for the Dev branch build labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/i18n kind/ui related to UI, icons, themes, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants