Automatic Python installation for Python plugins #319

jjw24 · 2021-01-31T06:53:54Z

If any Python plugins exist upon start up and the PythonDirectory in Settings is empty:

Check env "PATH" if Python path exists and set automatically, else
Prompt the user if they would like to install or select a Python directory,
If chosen to install, use Droplex library to download and install Python 3.9, then set the required variables for the plugin,
If chosen to select the directory, check location exists then set the required variables.
Load Python plugins

Zeroto521 · 2021-01-31T10:35:55Z

I want to know which python version will be installed. Complete version contains interpreter, idle and some script(includes pip and others).
So the installed python with interpreter and scripts will be fine

jjw24 · 2021-01-31T10:57:19Z

Python 3.9 will be installed

taooceros · 2021-02-01T08:25:00Z

Flow.Launcher.Core/Plugin/PluginsLoader.cs

+                else
+                {
+                    var installation = Task.Run(async () => { await DroplexPackage.Drop(App.python3_9_1).ConfigureAwait(false); });
+                    installation.Wait();


emmm since we are waiting it, why do we need to wrap it within the Task.Run?

@taooceros this should be synchronous, is there another way to do this without converting the calling methods async?

You can simply Wait the task do be done. DroplexPackage.Drop(App.python3_9_1).Wait(timeout), while timeout is the time to be waited. However I don't think would be great to let user wait downloading python at initialization, since it takes a while and will block other Flow's functionality.
I think this should be done async, disabling python plugin first if python not installed (also ask whether user has installed python similar to what has done in Everything plugin), and once it has downloaded successfully, enabling them.

I think it's fine because the installation has a prompt from Python, so user knows it's installing.

It does also ask the user if they want to select the location beforehand as well

oh ok I haven't looked at the newer part of the code.
However, I still think we should wait python installation at initialization, but let it does the job on background.
Is it possible to disable all python plugin and then later enable them after python installed?

I don't think python includes a great cdn so users in China may encounter significant of time of downloading it. However, I do agree with you that disabling and enabling plugins will bring quite a mess with at this stage.
Maybe don't load python plugin, and force restarting Flow after Python has installed?

python install file is only 28mbs, can you test it out see if it takes long

python install file is only 28mbs, can you test it out see if it takes long

Will take a try.

hmmm seems that people in China cannot directly finish download python because of timeout. I have encountered that the task was cancelled when I try to do this.

Thank you for testing. How long before it's timeout?

Is it timing out on connection or during the downloading?

Flow.Launcher.Core/Plugin/PluginsLoader.cs

pc223 · 2021-02-02T16:01:31Z

Just quick test this, when python 3.9 missing, Flow will auto install python 3.9 👍

Though my plugin is not usable right now (previously works with Flow-1.6.0), got 2 problems, related, but maybe outside scope of this PR:

When python packages missing (like flowlauncher, python-dotenv,...), Flow doesn't make a warning, should be at least an alert msgbox.
An exception related to RPC/Json stuff

2021-02-02 22:35:16.5874|ERROR|JsonRPCPlugin.Query|-------------------------- Begin exception --------------------------
2021-02-02 22:35:16.6100|ERROR|JsonRPCPlugin.Query|Exception when query <ts>
2021-02-02 22:35:16.6272|ERROR|JsonRPCPlugin.Query|Exception full name:
 <System.InvalidOperationException>
2021-02-02 22:35:16.6429|ERROR|JsonRPCPlugin.Query|Exception message:
 <The JSON property name for 'Flow.Launcher.Core.Plugin.JsonRPCQueryResponseModel.Result' collides with another property.>
2021-02-02 22:35:16.6625|ERROR|JsonRPCPlugin.Query|Exception stack trace:
 <   at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_SerializerPropertyNameConflict(JsonClassInfo jsonClassInfo, JsonPropertyInfo jsonPropertyInfo)
   at System.Text.Json.JsonClassInfo..ctor(Type type, JsonSerializerOptions options)
   at System.Text.Json.JsonSerializerOptions.GetOrAddClass(Type classType)
   at System.Text.Json.JsonSerializer.ReadCore(Type returnType, JsonSerializerOptions options, Utf8JsonReader& reader)
   at System.Text.Json.JsonSerializer.Deserialize(String json, Type returnType, JsonSerializerOptions options)
   at System.Text.Json.JsonSerializer.Deserialize[TValue](String json, JsonSerializerOptions options)
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.DeserializedResult(String output) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 66
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.Query(Query query) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 39>
2021-02-02 22:35:16.6863|ERROR|JsonRPCPlugin.Query|Exception source:
 <System.Text.Json>
2021-02-02 22:35:16.7061|ERROR|JsonRPCPlugin.Query|Exception target site:
 <Void ThrowInvalidOperationException_SerializerPropertyNameConflict(System.Text.Json.JsonClassInfo, System.Text.Json.JsonPropertyInfo)>
2021-02-02 22:35:16.7229|ERROR|JsonRPCPlugin.Query|Exception HResult:
 <-2146233079>
2021-02-02 22:35:16.7402|ERROR|JsonRPCPlugin.Query|-------------------------- End exception --------------------------

pc223 · 2021-02-02T17:33:33Z

Right now, Flow is using Python 3.9 directly, without virtualenv, this can be pretty annoying for python 3.9 user that use it for something else other than Flow.

So, after Flow install Python 3.9, I think Flow should make a new virtualenv, python -m venv flow_python_env, (takes like 20 seconds) that means Flow can freely install/uninstall any packages it want, no fear of conflict,

and change the python path to something like this in the settings page: flow_python_env\scripts\python.exe instead of the current one.

jjw24 · 2021-02-04T09:07:59Z

lets tackle this separately. This PR is to get python installed. We need to figure out how to auto install/uninstall requirement.txt cleanly

taooceros · 2021-02-05T03:16:02Z

@pc223 the rpc error has been fixed in #324
You can take a try on the build version of dev branch.
https://ci.appveyor.com/api/buildjobs/k827q6qyfge1a9l0/artifacts/Output%2FPackages%2FFlow-Launcher-v1.7.0.exe

pc223 · 2021-02-05T07:59:15Z

@pc223 the rpc error has been fixed in #324
You can take a try on the build version of dev branch.
https://ci.appveyor.com/api/buildjobs/k827q6qyfge1a9l0/artifacts/Output%2FPackages%2FFlow-Launcher-v1.7.0.exe

Nice! I'll try it out when I got the time 😄

taooceros · 2021-02-07T13:43:47Z

It should be downloading, but I am not sure. I think is is because the downloading speed is really slow, so timeout.

…

------------------ 原始邮件 ------------------ 发件人: "Jeremy Wu"<[email protected]>; 发送时间: 2021年2月7日(星期天) 晚上7:40 收件人: "Flow-Launcher/Flow.Launcher"<[email protected]>; 抄送: "天煞"<[email protected]>; "Mention"<[email protected]>; 主题: Re: [Flow-Launcher/Flow.Launcher] Automatic Python installation for Python plugins (#319) @jjw24 commented on this pull request. In Flow.Launcher.Core/Plugin/PluginsLoader.cs: > + if (File.Exists(pythonPath)) + { + settings.PythonDirectory = pythonDirectory; + Constant.PythonPath = pythonPath; + } + else + { + MessageBox.Show("Can't find python in given directory"); + } + } + } + } + else + { + var installation = Task.Run(async () => { await DroplexPackage.Drop(App.python3_9_1).ConfigureAwait(false); }); + installation.Wait(); Thank you for testing. How long before it's timeout? Is it timing out on connection or during the downloading? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Zeroto521 · 2021-02-07T14:37:30Z

Python 3.9 will be installed

This version will install the idle (GUI). The general user doesn't need that thing.

And the main version is 3.8 could be better because 3.9 released recently.

I recommend installing miniconda

Miniconda only contains interpreter and scripts.

Zeroto521 · 2021-02-09T10:58:52Z

Official python = idle + script(pip) + interpreter Miniconda = script(pip, conda) + interpreter If you thought miniconda didn’t have many packages another choice could be anaconda. Anaconda size is x.0GB+. But I’ m not prefer that.

…

在 2021年2月9日，14:23，taooceros ***@***.***> 写道： Python 3.9 will be installed This version will install the idle (GUI). The general user doesn't need that thing. And the main version is 3.8 could be better because 3.9 released recently. I recommend installing miniconda Miniconda only contains interpreter and scripts. But isn't miniconda include too much package that generally is not useful for Flow plugin? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Zeroto521 · 2021-02-09T11:00:31Z

Anyway package is the problem of next step not now.

jjw24 · 2021-02-10T10:26:00Z

This build from 20f895c should resolve download timeout issues. Thanks @taooceros

jjw24 · 2021-02-11T03:01:41Z

This is for 1.8.0 release, do not merge if approved.

taooceros · 2021-02-11T03:57:01Z

Are there any thing we still need to do for 1.7.1?

jjw24 · 2021-02-11T11:14:36Z

Hmm not at this stage. Although we don't have anything pending to go out urgently in 1.8.0 as well right, figure we might catch more bugs for 1.7.1

taooceros · 2021-02-11T11:18:32Z

Hmm not at this stage. Although we don't have anything pending to go out urgently in 1.8.0 as well right, figure we might catch more bugs for 1.7.1

I think we should at least release the fix in #322 since it blocks python plugins from working.

jjw24 · 2021-02-11T11:22:25Z

Hmm not at this stage. Although we don't have anything pending to go out urgently in 1.8.0 as well right, figure we might catch more bugs for 1.7.1

I think we should at least release the fix in #322 since it blocks python plugins from working.

Yeah makes sense, let's release 1.7.1, let's still hold off on 1.8.0 PRs for a bit to see if anymore bugs come up. What do you think?

taooceros · 2021-02-11T11:25:13Z

Yeah agree with you. Actually, I think we can release a pre-release before any large change, and see whether some bugs can be catched by that so that we can fix it before official release.

taooceros · 2021-02-11T11:27:43Z

Flow.Launcher.Core/Plugin/PluginsLoader.cs

+                    }
+                    else
+                    {
+                        Log.Error("PluginsLoader", 


What if user choose to install python on other path instead of the default path? I think we should allow selection if that it not found.

this is to auto set path after auto install. Users can choose the path before hand

Well I mean what if user don't choose to install python on the default path?

Happy Chinese New Year @taooceros :)

The installation will just install to the default location, it's a passive install, no prompt for install location

Happy New Year!!! 😃😃
Oh I see. That will be great!

jjw24 · 2021-02-11T11:34:01Z

Yeah agree with you. Actually, I think we can release a pre-release before any large change, and see whether some bugs can be catched by that so that we can fix it before official release.

Well, I don't know if people download that though, right now pre-releases needed to be manually downloaded

taooceros · 2021-02-11T11:36:59Z

I think wox allows user to choose downloading prerelease. Isn't flow containing one?

jjw24 · 2021-02-11T12:06:36Z

I think wox allows user to choose downloading prerelease. Isn't flow containing one?

Nah we haven't built it in. I would prefer something like squirrel's diff release where update is on new changes rather than the whole app. Problem with pre-releases is that it will just sit there forever and too much reliance on it to catch bugs is not effective, nobody wants to use a buggy version.

taooceros · 2021-02-11T14:05:12Z

emm you are right, but we still need more testing before large release, because sometimes it is hard for us to find bugs during our personal usage. Maybe we can ask someone who are willing to try the new feature to take a try on the prerelease, and after it becomes stable, then we release the official release.
I think the squirrel diff should be addressed later, and it is a feature of squirrel, though I don't understand why it doesn't generate the diff file for now. It should be quite useful for Flow because flow is self-contained, using diff update can avoid duplicate downloading the same .net core runtime.

jjw24 · 2021-02-12T07:24:24Z

@taooceros This is good to go out for 1.8.0?

taooceros · 2021-02-12T07:43:15Z

@taooceros This is good to go out for 1.8.0?

Ah yes!

jjw24 · 2021-02-14T01:20:20Z

Python 3.9 will be installed

This version will install the idle (GUI). The general user doesn't need that thing.

And the main version is 3.8 could be better because 3.9 released recently.

I recommend installing miniconda

Miniconda only contains interpreter and scripts.

Good pick up, I will need to look into miniconda along with the other suggestions and will change it later if needed.

jjw24 · 2021-02-14T01:21:45Z

We can discuss this further in the discord plugin-dev channel. Once decided it's just a matter of changing the droplex package.

add python installation

4933a2e

jjw24 added the enhancement New feature or request label Jan 31, 2021

jjw24 requested review from JohnTheGr8, SysC0mp, gdziedzic and taooceros January 31, 2021 06:53

jjw24 self-assigned this Jan 31, 2021

jjw24 linked an issue Jan 31, 2021 that may be closed by this pull request

Download dependent apps/services/tools automatically #286

Closed

taooceros reviewed Feb 1, 2021

View reviewed changes

Flow.Launcher.Core/Plugin/PluginsLoader.cs Show resolved Hide resolved

taooceros added this to the 1.7.0 milestone Feb 1, 2021

jjw24 modified the milestones: 1.7.0, 1.8.0 Feb 3, 2021

Merge remote-tracking branch 'origin/dev' into add_python_installation

39229e5

jjw24 added 2 commits February 4, 2021 21:18

Merge branch 'dev' into add_python_installation

385fabe

remove task

f3d0b88

jjw24 added 2 commits February 10, 2021 21:14

Merge branch 'dev' into add_python_installation

c714167

upgrade Droplex to use mirror site

20f895c

Update README.md

416ad3b

jjw24 requested a review from taooceros February 11, 2021 03:01

taooceros reviewed Feb 11, 2021

View reviewed changes

taooceros approved these changes Feb 12, 2021

View reviewed changes

jjw24 merged commit 040a590 into dev Feb 14, 2021

jjw24 deleted the add_python_installation branch February 14, 2021 01:24

jjw24 mentioned this pull request Feb 14, 2021

Resolve hot fix release #339

Merged

jjw24 mentioned this pull request Feb 22, 2021

Release 1.8.0 | Plugin 2.0.0 #363

Merged

Uh oh!

Automatic Python installation for Python plugins #319

Automatic Python installation for Python plugins #319

Uh oh!

Conversation

jjw24 commented Jan 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zeroto521 commented Jan 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Jan 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taooceros Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pc223 commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pc223 commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Feb 5, 2021

Uh oh!

pc223 commented Feb 5, 2021

Uh oh!

taooceros commented Feb 7, 2021 via email

Uh oh!

Zeroto521 commented Feb 7, 2021

Uh oh!

Zeroto521 commented Feb 9, 2021 via email

Uh oh!

Zeroto521 commented Feb 9, 2021

Uh oh!

jjw24 commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Feb 11, 2021

Uh oh!

taooceros commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Feb 11, 2021

Uh oh!

taooceros commented Feb 11, 2021

Uh oh!

jjw24 commented Feb 11, 2021

Uh oh!

taooceros commented Feb 11, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Jan 31, 2021 •

edited

Loading

Zeroto521 commented Jan 31, 2021 •

edited

Loading

jjw24 commented Jan 31, 2021 •

edited

Loading

jjw24 Feb 4, 2021 •

edited

Loading

taooceros Feb 4, 2021 •

edited

Loading

pc223 commented Feb 2, 2021 •

edited

Loading

pc223 commented Feb 2, 2021 •

edited

Loading

jjw24 commented Feb 4, 2021 •

edited

Loading

jjw24 commented Feb 10, 2021 •

edited

Loading

taooceros commented Feb 11, 2021 •

edited

Loading

jjw24 Feb 11, 2021 •

edited

Loading

jjw24 commented Feb 11, 2021 •

edited

Loading