Many exceptions in log file post 1.7 update

[deefrawley]

Describe the bug/issue
Just upgraded to v1.7 and getting a lot of exceptions in the log file. My currency converter plugin (python) also isn't working, though other plugins seem ok.

Your System

Windows build number: Microsoft Windows [Version 10.0.19042.746]
Flow Launcher version: 1.7

Flow Launcher Error Log

Attached.

2021-02-03.txt

[taooceros]

2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|-------------------------- Begin exception --------------------------
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Query Error
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception full name:
 <System.MissingMethodException>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception message:
 <Method not found: 'Flow.Launcher.Infrastructure.MatchResult Flow.Launcher.Infrastructure.StringMatcher.FuzzySearch(System.String, System.String)'.>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception stack trace:
 <   at Flow.Launcher.Plugin.Everything.Main.CreateResult(String keyword, SearchResult searchResult)
   at Flow.Launcher.Plugin.Everything.Main.Query(Query query) in C:\Workbench\Git\delete\Flow.Launcher.Plugin.Everything\Main.cs:line 55>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception source:
 <Flow.Launcher.Plugin.Everything>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception target site:
 <Flow.Launcher.Plugin.Result CreateResult(System.String, Flow.Launcher.Plugin.Everything.Everything.SearchResult)>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception HResult:
 <-2146233069>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|-------------------------- End exception --------------------------

This may due to the Interface changed in v1.7.0. I will update everything plugin to accomodate the change. But that's weird because it doesn't happen when we are testing.

[taooceros]

2021-02-03 15:11:42.8257|ERROR|JsonRPCPlugin.Query|-------------------------- Begin exception --------------------------
2021-02-03 15:11:42.8257|ERROR|JsonRPCPlugin.Query|Exception when query <cc>
2021-02-03 15:11:42.8257|ERROR|JsonRPCPlugin.Query|Exception full name:
 <System.InvalidOperationException>
2021-02-03 15:11:42.8257|ERROR|JsonRPCPlugin.Query|Exception message:
 <The JSON property name for 'Flow.Launcher.Core.Plugin.JsonRPCQueryResponseModel.Result' collides with another property.>
2021-02-03 15:11:42.8368|ERROR|JsonRPCPlugin.Query|Exception stack trace:
 <   at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_SerializerPropertyNameConflict(JsonClassInfo jsonClassInfo, JsonPropertyInfo jsonPropertyInfo)
   at System.Text.Json.JsonClassInfo..ctor(Type type, JsonSerializerOptions options)
   at System.Text.Json.JsonSerializerOptions.GetOrAddClass(Type classType)
   at System.Text.Json.JsonSerializer.ReadCore(Type returnType, JsonSerializerOptions options, Utf8JsonReader& reader)
   at System.Text.Json.JsonSerializer.Deserialize(String json, Type returnType, JsonSerializerOptions options)
   at System.Text.Json.JsonSerializer.Deserialize[TValue](String json, JsonSerializerOptions options)
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.DeserializedResult(String output) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 66
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.Query(Query query) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 39>
2021-02-03 15:11:42.8368|ERROR|JsonRPCPlugin.Query|Exception source:
 <System.Text.Json>
2021-02-03 15:11:42.8368|ERROR|JsonRPCPlugin.Query|Exception target site:
 <Void ThrowInvalidOperationException_SerializerPropertyNameConflict(System.Text.Json.JsonClassInfo, System.Text.Json.JsonPropertyInfo)>
2021-02-03 15:11:42.8368|ERROR|JsonRPCPlugin.Query|Exception HResult:
 <-2146233079>
2021-02-03 15:11:42.8368|ERROR|JsonRPCPlugin.Query|-------------------------- End exception --------------------------

This seems caused by the JSON library change.

[taooceros]

The reason that your plugin may not work may caused by the issue of JSONRPC issue. I will take a look on that, and reach out soon.
Thank you so much for reporting the issue, and I am sorry for the inconvenience.

[taooceros]

I don't understand why these various issue doesn't happen when we are testing. I will mark v1.7.0 as pre-release until this has been fixed.
So sorry for the inconvience.

[deefrawley]

No worries. I don't do any coding in VS / dot net (just python and VS Code) so perhaps I don't have the libraries and SDKs that you guys use. I can do a full uninstall/fresh reinstall of Flow if you're interested to see what happens?

[jjw24]

2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|-------------------------- Begin exception --------------------------
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Query Error
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception full name:
 <System.MissingMethodException>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception message:
 <Method not found: 'Flow.Launcher.Infrastructure.MatchResult Flow.Launcher.Infrastructure.StringMatcher.FuzzySearch(System.String, System.String)'.>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception stack trace:
 <   at Flow.Launcher.Plugin.Everything.Main.CreateResult(String keyword, SearchResult searchResult)
   at Flow.Launcher.Plugin.Everything.Main.Query(Query query) in C:\Workbench\Git\delete\Flow.Launcher.Plugin.Everything\Main.cs:line 55>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception source:
 <Flow.Launcher.Plugin.Everything>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception target site:
 <Flow.Launcher.Plugin.Result CreateResult(System.String, Flow.Launcher.Plugin.Everything.Everything.SearchResult)>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|Exception HResult:
 <-2146233069>
2021-02-03 15:11:42.1959|ERROR|EverythingPlugin.Query|-------------------------- End exception --------------------------

This may due to the Interface changed in v1.7.0. I will update everything plugin to accomodate the change. But that's weird because it doesn't happen when we are testing.

This one maybe because Everything plugin packs its own infrastructure dll if i remember correctly, which contains a very old version of fuzzy search

[jjw24]

I don't understand why these various issue doesn't happen when we are testing. I will mark v1.7.0 as pre-release until this has been fixed.
So sorry for the inconvience.

these exceptions are caused from the Everything and CurrencyCoverter plugin. Everything throws a missing method, which maybe due to the old dll, and CC throws the json dll collision exception, which is unknown to me. Each plugin uses its own dll library unless it's also referenced in the Plugin project, which then the AssemblyLoader will update the path to the dll path in from the Plugin project.

[taooceros]

Get an error when testing

[jjw24]

this is a python plugin, and those libraries such as the one in screenshot => dotenv requires you to use python's pip to install. if you dont know python, i can take a look

[taooceros]

Oh I get it. I can take a try, since I think the main issue is Json

[taooceros]

ok, find the issue.

Why there is two Result here