[Program Plugin] Fix program UID and other bugs #1496

VictoriousRaptor · 2022-10-22T05:54:37Z

Changes

Currently uid(path in this case) of ProgramSource is case sensitve so this can happen, which will cause duplicate results:

Fixed.
Fixed an issue that Flow prevents UWP apps from being completely uninstalled. See Fix for the issue where PT Run was preventing UWP apps from building in VS microsoft/PowerToys#5109.
Refactored class ProgramSource and removed class DisabledProgramSource.
Some small optimizations.
Merged Fix enable/disable/delete button in program plugin settings #1486 because it requires changes in this pr.
BUG: Disabling a program from being display in Programs should reindex data #1532

Tests

Changes in Fix enable/disable/delete button in program plugin settings #1486 and new editing dialogue logic.
No longer blocks uninstallation of uwp programs.
Duplicate paths of ProgramSource not allowed. (for both editing and adding)
UID of win32 programs and custom program sources is case-insensitve (to lowercase when set).
UID of Program Sources in config file can be converted to case-insensitive.
Improved index speed for custom sources (on my pc).
Disabling programs in context menu triggers a reindex.

1. Add Checkbox to edit program source window 2. Double click item to edit

Sharing violation may occur when reindexing after deleting user added source, causing some uwp programs can't be indexed. Don't actually know why it happens. Try to fix it.

See microsoft/PowerToys#5109

Plugins/Flow.Launcher.Plugin.Program/Views/Models/ProgramSource.cs

taooceros · 2022-11-04T03:43:48Z

Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs


        private static IEnumerable<Win32> UnregisteredPrograms(List<ProgramSource> sources, string[] suffixes, string[] protocols)
        {
            var paths = ExceptDisabledSource(sources.Where(s => Directory.Exists(s.Location) && s.Enabled)


Have you tested whether parallel give performance boost? In my very early test it is not so significant somehow

On my computer it is about 30% faster. I will do some more tests and show you the results.

Parallel gives up to 30% boost on my computer. Not always a significant boost but generally faster.

taooceros · 2022-11-04T03:45:06Z

Plugins/Flow.Launcher.Plugin.Program/FileChangeWatcher.cs

-
-namespace Flow.Launcher.Plugin.Program
-{
-    //internal static class FileChangeWatcher


why is this deleted sorry?

It's unused. The whole class is commented long ago.

jjw24 · 2022-11-14T06:41:27Z

@VictoriousRaptor please resolve conflict.

jjw24 · 2022-11-14T06:42:26Z

@VictoriousRaptor please update description on what you have tested with this change.

…low.Launcher into FixProgramUID

VictoriousRaptor · 2022-11-14T07:41:35Z

@VictoriousRaptor please update description on what you have tested with this change.

Updated. Consider a version bump of the plugin?

jjw24 · 2022-11-14T07:54:09Z

Check the release pr, I think this plugin already has a feature bump already.

jjw24

💯 👍 👍

VictoriousRaptor added 24 commits October 18, 2022 19:21

Add Checkbox to edit program source window

c56c343

1. Add Checkbox to edit program source window 2. Double click item to edit

Merge remote-tracking branch 'upstream/dev' into ProgramPluginUI

6bb3b39

Update text

3196dc5

Fix button text issue

dcec361

bugfix

569f69a

bugfix

bcd2b8d

Reindex when disable program from results

fac76af

Revert changes in Settings.cs

58ad92b

Move ProgramSource definition

81d2954

Make UID lowercase

c85af88

fix

4f2dc06

Remove unnecessary Count()

db67d3b

Remove DisabledProgramSource()

4da7a5e

manually set win32 uid when construct

bc54b07

Remove ProgramSource()

7832ab6

Remove unnecessary Count()

cc1e323

CA1829

8a488ad

bugfix

463f417

bugfix

cbcae41

Temporary fix for sharing violation

e72810c

Sharing violation may occur when reindexing after deleting user added source, causing some uwp programs can't be indexed. Don't actually know why it happens. Try to fix it.

set AppxPackageHelper to static

02b2375

CA1825

3362d1c

CA1822

d92ea58

Fix image file usage

84b1c26

See microsoft/PowerToys#5109

VictoriousRaptor enabled auto-merge October 22, 2022 05:54

Merge branch 'dev' into FixProgramUID

963c6ea

VictoriousRaptor self-assigned this Oct 22, 2022

VictoriousRaptor added bug Something isn't working Code Refactor labels Oct 22, 2022

taooceros reviewed Oct 23, 2022

View reviewed changes

Plugins/Flow.Launcher.Plugin.Program/Views/Models/ProgramSource.cs Outdated Show resolved Hide resolved

VictoriousRaptor added 2 commits November 3, 2022 18:38

Comments

85256ef

Implement object.Equals for uwp and win32

4725b0d

taooceros reviewed Nov 4, 2022

View reviewed changes

VictoriousRaptor added 8 commits November 4, 2022 14:15

Fix duplicate program sources when editing

ff430c7

Comment

5f6bcde

minor refactor

0079a88

Update Win32.cs

cdde5fa

Slightly speed up uwp index

1e8cc9a

remove unused property

59c355e

Merge branch 'dev' into FixProgramUID

76cf5f0

Merge branch 'dev' into FixProgramUID

c8b80f4

VictoriousRaptor mentioned this pull request Nov 14, 2022

BUG: Disabling a program from being display in Programs should reindex data #1532

Closed

1 task

VictoriousRaptor linked an issue Nov 14, 2022 that may be closed by this pull request

BUG: Disabling a program from being display in Programs should reindex data #1532

Closed

1 task

jjw24 added the review in progress Indicates that a review is in progress for this PR label Nov 14, 2022

jjw24 added this to the 1.10.0 milestone Nov 14, 2022

VictoriousRaptor added 4 commits November 14, 2022 15:15

Merge remote-tracking branch 'upstream/dev' into FixProgramUID

2f5789f

Merge branch 'FixProgramUID' of https://github.com/VictoriousRaptor/F…

225d002

…low.Launcher into FixProgramUID

Merge remote-tracking branch 'upstream/dev' into FixProgramUID

2ea310c

fix merge

f5701d4

jjw24 approved these changes Nov 14, 2022

View reviewed changes

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 14, 2022

jjw24 merged commit 2f57d4f into Flow-Launcher:dev Nov 14, 2022

This was referenced Nov 14, 2022

[Dev][Program Plugin] Fix uid case of user disabled programs #1537

Merged

[Dev] Program plugin settings enable/disable buttons #1356

Closed

jjw24 mentioned this pull request Dec 12, 2022

Release 1.10.0 | Plugin 3.0.0 #957

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Program Plugin] Fix program UID and other bugs #1496

[Program Plugin] Fix program UID and other bugs #1496

Uh oh!

VictoriousRaptor commented Oct 22, 2022 •

edited

Loading

Uh oh!

Uh oh!

taooceros Nov 4, 2022

Uh oh!

VictoriousRaptor Nov 4, 2022

Uh oh!

VictoriousRaptor Nov 4, 2022

Uh oh!

taooceros Nov 4, 2022

Uh oh!

VictoriousRaptor Nov 4, 2022

Uh oh!

jjw24 commented Nov 14, 2022

Uh oh!

jjw24 commented Nov 14, 2022

Uh oh!

VictoriousRaptor commented Nov 14, 2022

Uh oh!

jjw24 commented Nov 14, 2022 •

edited

Loading

Uh oh!

jjw24 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

[Program Plugin] Fix program UID and other bugs #1496

[Program Plugin] Fix program UID and other bugs #1496

Uh oh!

Conversation

VictoriousRaptor commented Oct 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Tests

Uh oh!

Uh oh!

taooceros Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

VictoriousRaptor Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

VictoriousRaptor Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

taooceros Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

VictoriousRaptor Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Nov 14, 2022

Uh oh!

jjw24 commented Nov 14, 2022

Uh oh!

VictoriousRaptor commented Nov 14, 2022

Uh oh!

jjw24 commented Nov 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

VictoriousRaptor commented Oct 22, 2022 •

edited

Loading

jjw24 commented Nov 14, 2022 •

edited

Loading