[Program Plugin] Fix program UID and other bugs

Flow.Launcher.Test/Plugins/ProgramTest.cs

@@ -19,7 +19,7 @@ public void WhenGivenPriReferenceValueShouldReturnCorrectFormat(string packageNa
             var app = new UWP.Application();
 
             // Act
-            var result = app.FormattedPriReferenceValue(packageName, rawPriReferenceValue);
+            var result = UWP.Application.FormattedPriReferenceValue(packageName, rawPriReferenceValue);
 
             // Assert
             Assert.IsTrue(result == expectedFormat, 

Plugins/Flow.Launcher.Plugin.Program/AddProgramSource.xaml

@@ -5,12 +5,12 @@
     xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
     Title="{DynamicResource flowlauncher_plugin_program_directory}"
-    Width="400"
+    Width="530"
     Background="{DynamicResource PopuBGColor}"
     Foreground="{DynamicResource PopupTextColor}"
+    ResizeMode="NoResize"
     SizeToContent="Height"
-    WindowStartupLocation="CenterScreen"
-    mc:Ignorable="d">
+    WindowStartupLocation="CenterScreen">
     <WindowChrome.WindowChrome>
         <WindowChrome CaptionHeight="32" ResizeBorderThickness="{x:Static SystemParameters.WindowResizeBorderThickness}" />
     </WindowChrome.WindowChrome>
@@ -19,7 +19,6 @@
             <RowDefinition />
             <RowDefinition Height="80" />
         </Grid.RowDefinitions>
-
         <StackPanel Grid.Row="0">
             <StackPanel>
                 <Grid>
@@ -53,53 +52,96 @@
                     </Button>
                 </Grid>
             </StackPanel>
-            <StackPanel Margin="26,12,26,0">
-                <StackPanel Margin="0,0,0,12">
+            <StackPanel Margin="26,0,26,0">
+                <StackPanel Grid.Row="0" Margin="0,0,0,12">
                     <TextBlock
                         Grid.Column="0"
                         Margin="0,0,0,0"
                         FontSize="20"
                         FontWeight="SemiBold"
-                        Text="{DynamicResource flowlauncher_plugin_program_directory}"
+                        Text="{DynamicResource flowlauncher_plugin_program_edit_program_source_title}"
                         TextAlignment="Left" />
                 </StackPanel>
-                <StackPanel Margin="0,0,0,10" Orientation="Horizontal">
-                    <TextBox
-                        Name="Directory"
-                        Width="268"
-                        Margin="0,7"
-                        VerticalAlignment="Center" />
-                    <Button
-                        Width="70"
-                        Margin="10"
-                        HorizontalAlignment="Right"
-                        Click="BrowseButton_Click"
-                        Content="{DynamicResource flowlauncher_plugin_program_browse}" />
+                <StackPanel>
+                    <TextBlock
+                        FontSize="14"
+                        Text="{DynamicResource flowlauncher_plugin_program_edit_program_source_tips}"
+                        TextAlignment="Left"
+                        TextWrapping="WrapWithOverflow" />
+                </StackPanel>
+
+                <StackPanel Margin="0,10,0,0" Orientation="Horizontal">
+                    <Grid Width="470">
+                        <Grid.RowDefinitions>
+                            <RowDefinition />
+                            <RowDefinition />
+                        </Grid.RowDefinitions>
+                        <Grid.ColumnDefinitions>
+                            <ColumnDefinition Width="Auto" />
+                            <ColumnDefinition Width="*" />
+                        </Grid.ColumnDefinitions>
+                        <TextBlock
+                            Grid.Row="0"
+                            Grid.Column="0"
+                            Margin="10"
+                            HorizontalAlignment="Left"
+                            VerticalAlignment="Center"
+                            FontSize="14"
+                            Text="{DynamicResource flowlauncher_plugin_program_directory}" />
+                        <DockPanel 
+                            Grid.Row="0" 
+                            Grid.Column="1" 
+                            LastChildFill="True">
+                            <Button
+                                Width="70"
+                                HorizontalAlignment="Right"
+                                Click="BrowseButton_Click"
+                                DockPanel.Dock="Right"
+                                Content="{DynamicResource flowlauncher_plugin_program_browse}" />
+                            <TextBox
+                                Name="Directory"
+                                Margin="10"
+                                VerticalAlignment="Center"
+                                HorizontalAlignment="Stretch" />
+                        </DockPanel>
+                        <TextBlock
+                            Grid.Row="1"
+                            Grid.Column="0"
+                            Margin="10"
+                            HorizontalAlignment="Left"
+                            VerticalAlignment="Center"
+                            FontSize="14"
+                            Text="{DynamicResource flowlauncher_plugin_program_enabled}" />
+                        <CheckBox x:Name="Chkbox"
+                            Grid.Row="1"
+                            Grid.Column="1"
+                            Margin="10,0"
+                            VerticalAlignment="Center" />
+                    </Grid>
                 </StackPanel>
             </StackPanel>
         </StackPanel>
         <Border
             Grid.Row="1"
+            Margin="0,14,0,0"
             Background="{DynamicResource PopupButtonAreaBGColor}"
             BorderBrush="{DynamicResource PopupButtonAreaBorderColor}"
             BorderThickness="0,1,0,0">
             <StackPanel HorizontalAlignment="Center" Orientation="Horizontal">
                 <Button
                     x:Name="btnCancel"
                     MinWidth="140"
-                    Margin="0,0,5,0"
+                    Margin="10,0,5,0"
                     Click="BtnCancel_OnClick"
                     Content="{DynamicResource cancel}" />
-
                 <Button
+                    x:Name="btnAdd"
                     MinWidth="140"
-                    Margin="5,0,0,0"
-                    HorizontalAlignment="Right"
-                    Click="ButtonAdd_OnClick"
+                    Margin="5,0,10,0"
+                    Click="BtnAdd_OnClick"
                     Content="{DynamicResource flowlauncher_plugin_program_update}"
                     Style="{DynamicResource AccentButtonStyle}" />
             </StackPanel>
         </Border>
     </Grid>
-
-</Window>
+</Window>

Plugins/Flow.Launcher.Plugin.Program/AddProgramSource.xaml.cs

@@ -9,26 +9,32 @@ namespace Flow.Launcher.Plugin.Program
     /// <summary>
     /// Interaction logic for AddProgramSource.xaml
     /// </summary>
-    public partial class AddProgramSource
+    public partial class AddProgramSource : Window
     {
         private PluginInitContext _context;
-        private Settings.ProgramSource _editing;
+        private ProgramSource _editing;
         private Settings _settings;
+        private bool update;
 
         public AddProgramSource(PluginInitContext context, Settings settings)
         {
             InitializeComponent();
             _context = context;
             _settings = settings;
             Directory.Focus();
+            Chkbox.IsChecked = true;
+            update = false;
+            btnAdd.Content = _context.API.GetTranslation("flowlauncher_plugin_program_add");
         }
 
-        public AddProgramSource(Settings.ProgramSource edit, Settings settings)
+        public AddProgramSource(PluginInitContext context, Settings settings, ProgramSource source)
         {
-            _editing = edit;
-            _settings = settings;
-
             InitializeComponent();
+            _context = context;
+            _editing = source;
+            _settings = settings;
+            update = true;
+            Chkbox.IsChecked = _editing.Enabled;
             Directory.Text = _editing.Location;
         }
 
@@ -47,34 +53,54 @@ private void BtnCancel_OnClick(object sender, RoutedEventArgs e)
             Close();
         }
 
-        private void ButtonAdd_OnClick(object sender, RoutedEventArgs e)
+        private void BtnAdd_OnClick(object sender, RoutedEventArgs e)
         {
-            string s = Directory.Text;
-            if (!System.IO.Directory.Exists(s))
+            string path = Directory.Text;
+            bool modified = false;
+            if (!System.IO.Directory.Exists(path))
             {
                 System.Windows.MessageBox.Show(_context.API.GetTranslation("flowlauncher_plugin_program_invalid_path"));
                 return;
             }
-            if (_editing == null)
+            if (!update)
             {
-                if (!ProgramSetting.ProgramSettingDisplayList.Any(x => x.UniqueIdentifier == Directory.Text))
+                if (!ProgramSetting.ProgramSettingDisplayList.Any(x => x.UniqueIdentifier.Equals(path, System.StringComparison.OrdinalIgnoreCase)))
                 {
-                    var source = new ProgramSource
-                    {
-                        Location = Directory.Text,
-                        UniqueIdentifier = Directory.Text
-                    };
-
+                    var source = new ProgramSource(path);
+                    modified = true;
                     _settings.ProgramSources.Insert(0, source);
                     ProgramSetting.ProgramSettingDisplayList.Add(source);
                 }
+                else
+                {
+                    System.Windows.MessageBox.Show(_context.API.GetTranslation("flowlauncher_plugin_program_duplicate_program_source"));
+                    return;
+                }
             }
             else
             {
-                _editing.Location = Directory.Text;
+                // Separate checks to avoid changing UniqueIdentifier of UWP
+                if (!_editing.Location.Equals(path, System.StringComparison.OrdinalIgnoreCase))
+                {
+                    if (ProgramSetting.ProgramSettingDisplayList
+                            .Any(x => x.UniqueIdentifier.Equals(path, System.StringComparison.OrdinalIgnoreCase)))
+                    {
+                        // Check if the new location is used
+                        // No need to check win32 or uwp, just override them
+                        System.Windows.MessageBox.Show(_context.API.GetTranslation("flowlauncher_plugin_program_duplicate_program_source"));
+                        return;
+                    }
+                    modified = true;
+                    _editing.Location = path;  // Changes UniqueIdentifier internally
+                }
+                if (_editing.Enabled != Chkbox.IsChecked)
+                {
+                    modified = true;
+                    _editing.Enabled = Chkbox.IsChecked ?? true;
+                }
             }
 
-            DialogResult = true;
+            DialogResult = modified;
             Close();
         }
     }

Plugins/Flow.Launcher.Plugin.Program/Languages/en.xaml

@@ -10,6 +10,7 @@
     <system:String x:Key="flowlauncher_plugin_program_add">Add</system:String>
     <system:String x:Key="flowlauncher_plugin_program_name">Name</system:String>
     <system:String x:Key="flowlauncher_plugin_program_enable">Enable</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_enabled">Enabled</system:String>
     <system:String x:Key="flowlauncher_plugin_program_disable">Disable</system:String>
     <system:String x:Key="flowlauncher_plugin_program_location">Location</system:String>
     <system:String x:Key="flowlauncher_plugin_program_all_programs">All Programs</system:String>
@@ -38,8 +39,12 @@
 
     <system:String x:Key="flowlauncher_plugin_program_pls_select_program_source">Please select a program source</system:String>
     <system:String x:Key="flowlauncher_plugin_program_delete_program_source">Are you sure you want to delete the selected program sources?</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_duplicate_program_source">Another program source with the same location alreaday exists.</system:String>
 
-    <system:String x:Key="flowlauncher_plugin_program_update">OK</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_edit_program_source_title">Program Source</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_edit_program_source_tips">Edit directory and status of this program source.</system:String>
+
+    <system:String x:Key="flowlauncher_plugin_program_update">Update</system:String>
     <system:String x:Key="flowlauncher_plugin_program_only_index_tip">Program Plugin will only index files with selected suffixes and .url files with selected protocols.</system:String>
     <system:String x:Key="flowlauncher_plugin_program_update_file_suffixes">Successfully updated file suffixes</system:String>
     <system:String x:Key="flowlauncher_plugin_program_suffixes_cannot_empty">File suffixes can't be empty</system:String>

Plugins/Flow.Launcher.Plugin.Program/Logger/ProgramLogger.cs

@@ -1,13 +1,8 @@
 using NLog;
-using NLog.Config;
-using NLog.Targets;
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Runtime.CompilerServices;
 using System.Security;
-using Flow.Launcher.Infrastructure;
-using Flow.Launcher.Infrastructure.UserSettings;
 
 namespace Flow.Launcher.Plugin.Program.Logger
 {