Fix shell cmd command with quote and space #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjw24
reviewed
May 15, 2022
| info.Arguments = $"{(_settings.LeaveShellOpen ? "/k" : "/c")} {command}"; | ||
|
|
||
| // ArgumentList may break original shell command separation with quote. | ||
| // info.ArgumentList.Add(_settings.LeaveShellOpen ? "/k" : "/c"); |
Member
There was a problem hiding this comment.
These commented out code is not removed?
Member
Author
There was a problem hiding this comment.
yes we can remove it. Probably it would be better to change all argumentlist to plain arguments, because we want to allow user to have the most control over the argument they are writing.
Member
|
Any chance we can add tests to this? |
Member
Author
I have limited idea about how to write test for this. |
Member
|
This is still not working, you can test by running |
Member
Author
|
I haven't given another round of test, but I think you need to type |
Member
|
yes you are right 🤦 too early in the day for me right now lol |
jjw24
force-pushed
the
fix_cmd_command_with_blank
branch
from
5b1554d to
9b894b3
Compare
jjw24
added a commit
that referenced
this pull request
Jul 23, 2022
Fix shell cmd command with quote and space
Merged
jjw24
added a commit
that referenced
this pull request
Jul 24, 2022
* Merge pull request #1205 from Flow-Launcher/fix_cmd_command_with_blank Fix shell cmd command with quote and space * Bump NuGet.CommandLine from 5.4.0 to 5.7.2 (#1241) * Merge pull request #1098 from Flow-Launcher/ScrollToSelectedPlugin Scroll to selected item when expanded or size changed * fix RemoveOldQueryResults NullPointerException (#1204) * Merge pull request #1005 from Flow-Launcher/KillProcess Use Cancellation Token to avoid potential race tracing issue * Merge pull request #1187 from Flow-Launcher/update_python_download_mirrors Update Python download mirrors * Merge pull request #1108 from Flow-Launcher/CalculatorDecimalSeparator Respect Decimal Separator for query not just result * Merge pull request #1087 from Flow-Launcher/turnoff_replace_win_r_shell Set Shell plugin's default replace Win R hotkey to off * Merge pull request #1077 from Flow-Launcher/fix_explorer_button_visibility Fix incorrect button visibility in Explorer's expander control * Merge pull request #1076 from Flow-Launcher/fix_path_search_with_index Fix the use of index in path search * Merge pull request #1071 from medlir/fix-browser-bookmarks-plugin-exception avoid exception in ChromiumBookmarkLoader.cs * Merge pull request #1056 from Flow-Launcher/fix_context_menu_typo Fix typo for plugin title in context menu and WindowsSettings name * Merge pull request #1119 from onesounds/antialising Remove All Cleartype Rendering * Version bump * Remove Calculator plugin CopyText feature for 1.9.4 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1085