Skip to content

Fix the use of index in path search #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2022
Merged

Fix the use of index in path search #1076

merged 2 commits into from
Jun 28, 2022

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Mar 13, 2022 •
edited
Loading

  • By default path search should not use index, this solves the issue where if a path e.g. C:\blah\ is not included users should still able to pull it up with the path search.
  • Allow option to enable/disable the use of index in path search via settings.

Related issue #1064

Tested:

  • When option is checked path's subdirectories & files would not show up when not indexed.
  • When option is checked but path added to Excluded, the path's subdirectories & files would still show up and as 'not indexed'.
  • When option is not checked, path's subdirectories & files show up even if it is not indexed.

@jjw24 jjw24 added the bug Something isn't working label Mar 13, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Mar 13, 2022
@jjw24 jjw24 self-assigned this Mar 13, 2022
@jjw24 jjw24 enabled auto-merge March 13, 2022 03:33
taooceros
taooceros reviewed Mar 13, 2022
View reviewed changes
@taooceros taooceros added the review in progress Indicates that a review is in progress for this PR label Jun 10, 2022
@jjw24 jjw24 merged commit 377c7d7 into dev Jun 28, 2022
@jjw24 jjw24 deleted the fix_path_search_with_index branch June 28, 2022 13:44
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Jul 1, 2022
@jjw24 jjw24 modified the milestones: 1.10.0, 1.9.4 Jul 23, 2022
jjw24 added a commit that referenced this pull request Jul 23, 2022
@jjw24
Merge pull request #1076 from Flow-Launcher/fix_path_search_with_index
50736bb 
Fix the use of index in path search
@jjw24 jjw24 mentioned this pull request Jul 23, 2022
Merged
jjw24 added a commit that referenced this pull request Jul 24, 2022
@jjw24
Release 1.9.4 (#1287)
6dedb4f 
* Merge pull request #1205 from Flow-Launcher/fix_cmd_command_with_blank

Fix shell cmd command with quote and space

* Bump NuGet.CommandLine from 5.4.0 to 5.7.2 (#1241)

* Merge pull request #1098 from Flow-Launcher/ScrollToSelectedPlugin

Scroll to selected item when expanded or size changed

* fix RemoveOldQueryResults NullPointerException (#1204)

* Merge pull request #1005 from Flow-Launcher/KillProcess

Use Cancellation Token to avoid potential race tracing issue

* Merge pull request #1187 from Flow-Launcher/update_python_download_mirrors

Update Python download mirrors

* Merge pull request #1108 from Flow-Launcher/CalculatorDecimalSeparator

Respect Decimal Separator for query not just result

* Merge pull request #1087 from Flow-Launcher/turnoff_replace_win_r_shell

Set Shell plugin's default replace Win R hotkey to off

* Merge pull request #1077 from Flow-Launcher/fix_explorer_button_visibility

Fix incorrect button visibility in Explorer's expander control

* Merge pull request #1076 from Flow-Launcher/fix_path_search_with_index

Fix the use of index in path search

* Merge pull request #1071 from medlir/fix-browser-bookmarks-plugin-exception

avoid exception in ChromiumBookmarkLoader.cs

* Merge pull request #1056 from Flow-Launcher/fix_context_menu_typo

Fix typo for plugin title in context menu and WindowsSettings name

* Merge pull request #1119 from onesounds/antialising

Remove All Cleartype Rendering

* Version bump

* Remove Calculator plugin CopyText feature for 1.9.4 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taooceros taooceros taooceros approved these changes

@Garulf Garulf Awaiting requested review from Garulf

@JohnTheGr8 JohnTheGr8 Awaiting requested review from JohnTheGr8

@onesounds onesounds Awaiting requested review from onesounds

@SysC0mp SysC0mp Awaiting requested review from SysC0mp

Assignees

@jjw24 jjw24

Labels

bug Something isn't working

Projects

Work In Progress
Archived in project

Milestone

1.9.4

Development

Successfully merging this pull request may close these issues.

3 participants

@jjw24 @taooceros