Include analyzers in the build

[Yusyuriv]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The project file Flow.Launcher.Localization.csproj has been updated to refine its build and packaging configuration. New properties have been incorporated to control build output, dependency management, and packaging behavior. Additionally, project references to analyzer and source generator projects now include a restriction attribute, and specific items have been added to package DLLs under designated paths while keeping them hidden from consumers.

Changes

File(s)	Summary of Changes
Flow.Launcher.Localization.csproj (PropertyGroup)	Added properties: <IncludeBuildOutput>false</IncludeBuildOutput>, <DevelopmentDependency>true</DevelopmentDependency>, <NoPackageAnalysis>true</NoPackageAnalysis>, <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>.
Flow.Launcher.Localization.csproj (ProjectReference)	Updated project references for the Analyzers and SourceGenerators projects with PrivateAssets="All".
Flow.Launcher.Localization.csproj (New ItemGroup)	Added <None> entries for the analyzer and source generator DLLs to be packed into the NuGet package at analyzers/dotnet/cs with Visible="false".

Poem

I'm a happy rabbit in the fields of code,
Hopping through properties on my winding road.
Dependencies tucked away, safe and sound,
Packaged DLLs quietly abound.
With whiskers twitching in the light of day,
I celebrate these changes in a joyful, bouncy way! 🐰🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0995c9b and e7d2d65.

📒 Files selected for processing (1)

• Flow.Launcher.Localization/Flow.Launcher.Localization.csproj (1 hunks)

🔇 Additional comments (3)

Flow.Launcher.Localization/Flow.Launcher.Localization.csproj (3)

3-13: Property Configuration Enhancements
The new properties—<IncludeBuildOutput>false</IncludeBuildOutput>, <DevelopmentDependency>true</DevelopmentDependency>, <NoPackageAnalysis>true</NoPackageAnalysis>, and <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>—are correctly added to fine-tune the build and packaging behavior. They ensure that unnecessary build outputs aren’t packaged and that development dependencies remain internal. Please verify that these settings align with your overall release and packaging strategies.

---

15-24: Project Reference Isolation
The updates to the <ProjectReference> entries with PrivateAssets="All" for both the analyzers and source generators effectively encapsulate these dependencies within the project, preventing them from being exposed transitively. This is a standard best practice for managing internal build components.

---

26-39: Analyzer and Source Generator Packaging Setup
The new <ItemGroup> entries correctly include the analyzer and source generator DLLs in the package. By setting Pack="true", specifying PackagePath="analyzers/dotnet/cs", and marking them as Visible="false", the configuration is tailored to include these components in the NuGet package without exposing them to consumers. Please ensure that the $(OutputPath) variable resolves as expected during the build process so that these DLLs are correctly located.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Yusyuriv]

I think this is a weird workaround solution. Your solution from #3 is much more straightforward, so we'll go with that one.

Update: Learned a little more about this. Apparently, it is a normal thing to do, and it's required either way, so I'm reopening this PR.