Use one project for all analyzers and downgrade version to 0.0.1 #3
Conversation
📝 WalkthroughWalkthroughThe pull request removes several documentation and project files related to unshipped and shipped analyzer releases, streamlining the solution by removing references to analyzers and source generators. It also updates documentation in one file to introduce new localization rules and refactors namespace declarations across analyzer, diagnostics, and generator code files. Additionally, the main project file has been updated by replacing project references with package references and adjusting the version. Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Flow.Launcher.Localization/AnalyzerReleases.Unshipped.md (2)
1-1: Potential Formatting Issue with BOM and Leading Semicolon.
The first line starts with a BOM and a semicolon (; Unshipped analyzer release). Please verify whether the semicolon is intentional (perhaps as a stylistic marker) or if it’s an artifact that might affect rendering or consistency in Markdown.🧰 Tools
🪛 LanguageTool
[uncategorized] ~1-~1: Loose punctuation mark.
Context: ; Unshipped analyzer release ; https://gi...(UNLIKELY_OPENING_PUNCTUATION)
2-2: Encourage Proper URL Formatting.
The bare URL on line 2 may trigger markdownlint warnings (e.g., MD034, no-bare-urls). Consider wrapping the URL in angle brackets or converting it into a proper Markdown hyperlink (e.g.,[Documentation](https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md)) for better compliance and readability.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
2-2: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
Flow.Launcher.Localization.Analyzers/AnalyzerReleases.Unshipped.md(0 hunks)Flow.Launcher.Localization.Analyzers/Flow.Launcher.Localization.Analyzers.csproj(0 hunks)Flow.Launcher.Localization.SourceGenerators/AnalyzerReleases.Shipped.md(0 hunks)Flow.Launcher.Localization.SourceGenerators/Flow.Launcher.Localization.SourceGenerators.csproj(0 hunks)Flow.Launcher.Localization.slnx(0 hunks)Flow.Launcher.Localization/AnalyzerReleases.Unshipped.md(1 hunks)Flow.Launcher.Localization/Analyzers/ContextAvailabilityAnalyzer.cs(1 hunks)Flow.Launcher.Localization/Analyzers/ContextAvailabilityAnalyzerCodeFixProvider.cs(2 hunks)Flow.Launcher.Localization/Analyzers/OldGetTranslateAnalyzer.cs(1 hunks)Flow.Launcher.Localization/Analyzers/OldGetTranslateAnalyzerCodeFixProvider.cs(3 hunks)Flow.Launcher.Localization/Diagnostics/AnalyzerDiagnostics.cs(1 hunks)Flow.Launcher.Localization/Diagnostics/SourceGeneratorDiagnostics.cs(1 hunks)Flow.Launcher.Localization/Flow.Launcher.Localization.csproj(1 hunks)Flow.Launcher.Localization/Generators/LocalizeSourceGenerator.cs(1 hunks)
💤 Files with no reviewable changes (5)
- Flow.Launcher.Localization.SourceGenerators/AnalyzerReleases.Shipped.md
- Flow.Launcher.Localization.slnx
- Flow.Launcher.Localization.Analyzers/AnalyzerReleases.Unshipped.md
- Flow.Launcher.Localization.SourceGenerators/Flow.Launcher.Localization.SourceGenerators.csproj
- Flow.Launcher.Localization.Analyzers/Flow.Launcher.Localization.Analyzers.csproj
✅ Files skipped from review due to trivial changes (7)
- Flow.Launcher.Localization/Diagnostics/AnalyzerDiagnostics.cs
- Flow.Launcher.Localization/Analyzers/ContextAvailabilityAnalyzer.cs
- Flow.Launcher.Localization/Generators/LocalizeSourceGenerator.cs
- Flow.Launcher.Localization/Analyzers/ContextAvailabilityAnalyzerCodeFixProvider.cs
- Flow.Launcher.Localization/Analyzers/OldGetTranslateAnalyzer.cs
- Flow.Launcher.Localization/Analyzers/OldGetTranslateAnalyzerCodeFixProvider.cs
- Flow.Launcher.Localization/Diagnostics/SourceGeneratorDiagnostics.cs
🧰 Additional context used
🪛 LanguageTool
Flow.Launcher.Localization/AnalyzerReleases.Unshipped.md
[uncategorized] ~1-~1: Loose punctuation mark.
Context: ; Unshipped analyzer release ; https://gi...
(UNLIKELY_OPENING_PUNCTUATION)
🪛 markdownlint-cli2 (0.17.2)
Flow.Launcher.Localization/AnalyzerReleases.Unshipped.md
2-2: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (3)
Flow.Launcher.Localization/AnalyzerReleases.Unshipped.md (1)
8-12: New Analyzer Rules Added.
The table entries for the new analyzer rules (FLAN0001 through FLAN0005) are formatted consistently and clearly communicate the rule details. The changes integrate well with the existing entries.Flow.Launcher.Localization/Flow.Launcher.Localization.csproj (2)
4-4: Version Downgrade Implemented
The version has been updated to0.0.1to reflect the project's current pre-production state. Ensure that this downgrade is clearly communicated in your release notes and documentation so that downstream consumers are aware of the project’s non-production status.
11-17: Consolidated Package References for Analyzers
The removal of project references in favor of NuGet package references (Microsoft.CodeAnalysis.Analyzers,Microsoft.CodeAnalysis.CSharp, andMicrosoft.CodeAnalysis.CSharp.Workspaces) is implemented correctly. The<PrivateAssets>and<IncludeAssets>settings for the analyzers package are configured appropriately to prevent unintended transitivity. Please verify that these packages satisfy all analyzer and source generation requirements after consolidation.
|
Actually, I just created a fresh plugin project, and I can't seem to make this PR work. The package is included: <ItemGroup>
<PackageReference Include="Flow.Launcher.Localization" Version="0.0.1">
<OutputItemType>Analyzer</OutputItemType>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Flow.Launcher.Plugin" Version="4.4.0" />
<AdditionalFiles Include="Languages\en.xaml" />
</ItemGroup>it builds without issues, but doesn't complain about the property being private: public class Class1: IPlugin, IPluginI18n {
private static PluginInitContext Context { get; set; } = null!; |
I will check it now. |
Using
Flow.Launcher.Localizationprevents analyzers from being packed into the NuGet package. To resolve this, we should consolidate them into a single project.Additionally, I recommend downgrading the version to 0.0.1 since this project is not intended for production use yet.