Skip to content

build: gradle plugin download sdl / introspection integration tests #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 25, 2023
Merged

build: gradle plugin download sdl / introspection integration tests #1656

merged 6 commits into from
Jan 25, 2023

Conversation

@dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Jan 24, 2023

📝 Description

Migrate download sdl task and introspection task integration tests to a composite build. Failure scenarios (i.e. timeout) is still run through GradleRunner in the plugin project.

🔗 Related Issues

dariuszkuc
dariuszkuc commented Jan 24, 2023
View reviewed changes
plugins/graphql-kotlin-gradle-plugin/src/integration/download-sdl-timeout/build.gradle.kts
import com.expediagroup.graphql.plugin.gradle.tasks.GraphQLDownloadSDLTask

plugins {
kotlin("jvm") version "1.7.21"
Copy link
Collaborator Author

@dariuszkuc dariuszkuc Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could potentially load this from version catalog (but would have to update the test logic to copy the toml file - will look into this later)

@dariuszkuc
Copy link
Collaborator Author

dariuszkuc commented Jan 24, 2023 •
edited
Loading

NOTE: big size of the PR is due to introspection/sdl results (1946 lines changed) copied over for wiremock in the composite build.

@dariuszkuc dariuszkuc enabled auto-merge (squash) January 24, 2023 23:16
@samuelAndalon samuelAndalon self-requested a review January 25, 2023 16:23
@dariuszkuc dariuszkuc merged commit 0459612 into ExpediaGroup:master Jan 25, 2023
@dariuszkuc dariuszkuc deleted the plugin_it branch January 25, 2023 16:23
@dariuszkuc dariuszkuc mentioned this pull request Jan 26, 2023
Merged
dariuszkuc added a commit that referenced this pull request Jan 26, 2023
@dariuszkuc
build: migrate remaining gradle plugin integration tests (#1658)
00b1731 
### 📝 Description

Migrate last remaining Gradle integration tests to a composite build.

### 🔗 Related Issues

* #1654
* #1656
* #1657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelAndalon samuelAndalon samuelAndalon approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dariuszkuc @samuelAndalon