build: move gradle plugin integration tests to composite build #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves Gradle plugin integration tests to a composite builds. Benefits: * faster build - integration tests are executed as composite build which can be built in parallel and utilize Gradle build cache to speed up process * easier env variable sharing - we no longer need to pass system properties to specify which version of library to use, `graphql-kotlin` libraries can be referenced without version as they are part of the build and we can rely on same version catalog as main build * easier to debug build problems - each integration test is now a valid Gradle project that can be easily loaded in IntelliJ (or build from cmd line)
Collaborator
Author
|
NOTE: IntelliJ auto creates those gradle wrapper files for each composite build, will look whether we can easily drop them once I move all the integration tests. |
Collaborator
Author
|
Since the PR is already pretty big -> I'll follow up with separate ones for migrating remaining integration tests. |
samuelAndalon
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Moves Gradle plugin integration tests to a composite builds.
Benefits:
graphql-kotlinlibraries can be referenced without version as they are part of the build and we can rely on same version catalog as main build🔗 Related Issues