Skip to content

Disable git blame menu when blame is not available. #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2021
Merged

Disable git blame menu when blame is not available. #536

merged 3 commits into from
Jul 13, 2021

Conversation

intjftw
Copy link
Collaborator

@intjftw intjftw commented Jul 5, 2021

Git blame menu (Team --> Blame) does not appear in the right-click menu on clicking a node or a file if:

@intjftw intjftw added Kind: Enhancement 🌟 Plugin: Git Issues with the "Version control navigation" (Git) plugin. Target: WebGUI Issues related to the web frontend. labels Jul 5, 2021
@intjftw intjftw requested review from whisperity and mcserep July 5, 2021 15:40
whisperity
whisperity reviewed Jul 5, 2021
View reviewed changes
whisperity
whisperity approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Huh, I didn't know about this isInRepository flag before. Certainly made it much easier to implement, it seems.

@intjftw
Copy link
Collaborator Author

intjftw commented Jul 6, 2021

Yes! Although I knew the necessary functions in the libgit2 library, but I'm glad I found our implementation before trying to implement my own solution. 😅

@intjftw
Bugfix: isRepositoryAvailable shoud return true if the version direct…
8795fbb 
…ory is present and not empty in the workspace.
mcserep
mcserep approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mcserep mcserep merged commit a4b4630 into Ericsson:master Jul 13, 2021
@mcserep mcserep deleted the disable_git_menu branch July 13, 2021 08:31
@mcserep mcserep added this to the Release Flash milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whisperity whisperity whisperity approved these changes

@mcserep mcserep mcserep approved these changes

Assignees
No one assigned
Labels
Kind: Enhancement 🌟 Plugin: Git Issues with the "Version control navigation" (Git) plugin. Target: WebGUI Issues related to the web frontend.
Projects
None yet
Milestone
Release Flash
Development

Successfully merging this pull request may close these issues.

"Team -> Blame" (Git) options should only be visible if its applicable
3 participants
@intjftw @whisperity @mcserep