Skip to content

Conversation

@theolivenbaum
Copy link

Hi @GregorBiswanger , just saw that you merged my other PR.

If you want, here are the remaining changes I've done since then - lots of fixes, updates, etc...

@GregorBiswanger
Copy link
Member

I would like to merge your pull requests.. can you please check the conflicted ones.

@GregorBiswanger
Copy link
Member

@theolivenbaum I would like to merge your pull requests.. can you please check the conflicted ones.

@theolivenbaum
Copy link
Author

theolivenbaum commented Jul 12, 2022

Hi @GregorBiswanger - I unfortunately don't have the bandwidth right now to review this changes - specially to make sure this doesn't introduce any new issues due to the big changes I added on our fork to be async-only. I'm keeping our fork of ElectronNet up to date with Electron releases and I think it would be awesome to merge this back to the main repo, but I can't commit on the work for that right now. Maybe someone from the community could take over the work?

@theolivenbaum theolivenbaum changed the title Updates all the way to 18.0.2 Updates all the way to 19.0.8 Jul 12, 2022
@GregorBiswanger GregorBiswanger mentioned this pull request Jul 18, 2022
@lafleurh
Copy link

@GregorBiswanger Let me know what help you need bringing this in. We are looking to update our branch and contribute some WiX stuff back. I am not able to build or run the latest code.

@GregorBiswanger
Copy link
Member

@lafleurh There are some merge conflicts. I only have a few weeks time.

@GregorBiswanger GregorBiswanger merged commit d3aa978 into ElectronNET:master Jul 28, 2022
@GregorBiswanger
Copy link
Member

@theolivenbaum I merged all and the project should build without problems. I don´t know why you implement the SocketIO source directly?! I was think, you wont to use the nuge library?! Please check the current merged version on our repo.. Thanks!

@GregorBiswanger
Copy link
Member

@theolivenbaum I get the following exception when running a new "Hello World" project.

I had installed the Nito.AsyncEx.Coordination Library via NuGet at the API project. Why do we need this dependency? Can you do without?

electron.cmd "..\..\main.js"

Electron Socket IO Port: 8000
Electron Socket started on port 8000 at 127.0.0.1
.NET Core Port: 8001
stderr: Unhandled exception.
stderr: Unhandled exception.
stderr: System.TypeInitializationException: The type initializer for 'ElectronNET.API.BridgeConnector' threw an exception.
 ---> System.IO.FileNotFoundException: Could not load file or assembly 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'. Das System kann die angegebene Datei nicht finden.
File name: 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'
   at ElectronNET.API.BridgeConnector..cctor()
   --- End of inner exception stack trace ---
   at ElectronNET.API.BridgeConnector.get_Logger() in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 536
   at ElectronNET.API.BridgeConnector.Log(String formatString, Object[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 396
   at ElectronNET.API.WebHostBuilderExtensions.UseElectron(IWebHostBuilder builder, String[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\WebHostBuilderExtensions.cs:line 26
   at Program.<Main>$(String[] args) in C:\Users\Gregor\source\repos\ElectronNetNewTest\Program.cs:line 5
   at Program.<Main>(String[] args)

stderr: System.TypeInitializationException: The type initializer for 'ElectronNET.API.BridgeConnector' threw an exception.
 ---> System.IO.FileNotFoundException: Could not load file or assembly 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'. Das System kann die angegebene Datei nicht finden.
File name: 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'
   at ElectronNET.API.BridgeConnector..cctor()
   --- End of inner exception stack trace ---
   at ElectronNET.API.BridgeConnector.get_Logger() in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 536
   at ElectronNET.API.BridgeConnector.Log(String formatString, Object[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 396
   at ElectronNET.API.WebHostBuilderExtensions.UseElectron(IWebHostBuilder builder, String[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\WebHostBuilderExtensions.cs:line 26
   at Program.<Main>$(String[] args) in C:\Users\Gregor\source\repos\ElectronNetNewTest\Program.cs:line 5
   at Program.<Main>(String[] args)

.NET process exited with code 3762504530
Will quit Electron, as exit code != 0 (got 3762504530)

@GregorBiswanger
Copy link
Member

@theolivenbaum Can you please see the error message. ☝️

@lafleurh
Copy link

lafleurh commented Oct 3, 2022

I managed to get it working for us. See https://github.com/evoleap/Electron.NET/tree/master19 bit I'm waiting on another project and we have some breaking changes to rectify. Also, we went to .net 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants