-
-
Notifications
You must be signed in to change notification settings - Fork 738
Updates all the way to 19.0.8 #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would like to merge your pull requests.. can you please check the conflicted ones. |
|
@theolivenbaum I would like to merge your pull requests.. can you please check the conflicted ones. |
|
Hi @GregorBiswanger - I unfortunately don't have the bandwidth right now to review this changes - specially to make sure this doesn't introduce any new issues due to the big changes I added on our fork to be async-only. I'm keeping our fork of ElectronNet up to date with Electron releases and I think it would be awesome to merge this back to the main repo, but I can't commit on the work for that right now. Maybe someone from the community could take over the work? |
|
@GregorBiswanger Let me know what help you need bringing this in. We are looking to update our branch and contribute some WiX stuff back. I am not able to build or run the latest code. |
|
@lafleurh There are some merge conflicts. I only have a few weeks time. |
|
@theolivenbaum I merged all and the project should build without problems. I don´t know why you implement the SocketIO source directly?! I was think, you wont to use the nuge library?! Please check the current merged version on our repo.. Thanks! |
|
@theolivenbaum I get the following exception when running a new "Hello World" project. I had installed the Nito.AsyncEx.Coordination Library via NuGet at the API project. Why do we need this dependency? Can you do without? |
|
@theolivenbaum Can you please see the error message. ☝️ |
|
I managed to get it working for us. See https://github.com/evoleap/Electron.NET/tree/master19 bit I'm waiting on another project and we have some breaking changes to rectify. Also, we went to .net 6. |
Hi @GregorBiswanger , just saw that you merged my other PR.
If you want, here are the remaining changes I've done since then - lots of fixes, updates, etc...