Skip to content

Conversation

@lukebordonaro
Copy link

Closes #666

@lukebordonaro
Copy link
Author

I initially only edited browserWindows.ts and ran tsc, but it resulted in a lot of changes to js and js.map files. I decided to make the necessary changes to browserWindows.js manually for this PR - let me know if you'd like me to run tsc instead.

@GregorBiswanger GregorBiswanger added this to the 18.6.1 milestone Apr 6, 2022
@GregorBiswanger GregorBiswanger self-assigned this Apr 6, 2022
@GregorBiswanger GregorBiswanger merged commit 709780f into ElectronNET:master Apr 6, 2022
theolivenbaum added a commit to theolivenbaum/Electron.NET that referenced this pull request Jun 9, 2022
@arun04cbe
Copy link

Hi @GregorBiswanger @MutatedGamer
The code for making the popups modal has been merged but when I check in the repo, it seems the code is not reflected.
Can you kindly check this to get the modal popups working?
(FYI - This has not been reflected in the latest Electron.NET version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting Modal = true in BrowserOptions does not work

3 participants