Skip to content

Allow ignoring certificate errors #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Allow ignoring certificate errors #626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d655c
Allow ignoring certificate errors when using an untrusted self-signed…
javierlarota Nov 26, 2021
431e401
Feedback from code review. Improving logging of the domain names that…
javierlarota Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion ElectronNET.Host/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if (manifestJsonFile.singleInstance || manifestJsonFile.aspCoreBackendPort) {
args.forEach(parameter => {
const words = parameter.split('=');

if(words.length > 1) {
if (words.length > 1) {
app.commandLine.appendSwitch(words[0].replace('--', ''), words[1]);
} else {
app.commandLine.appendSwitch(words[0].replace('--', ''));
Expand All @@ -75,6 +75,27 @@ if (manifestJsonFile.singleInstance || manifestJsonFile.aspCoreBackendPort) {
}
}

// Bypass all SSL/TLS certificate errors. -- Less secure.
if (manifestJsonFile.ignoreAllCertificateErrors) {
console.log('All SSL/TLS Certificate errors will be ignored.');
app.commandLine.appendSwitch('ignore-certificate-errors');
}

// Bypass SSL/TLS certificate errors only for the domain names specified in the electron.manifest.json file.
if (manifestJsonFile.hasOwnProperty('domainNamesToIgnoreCertificateErrors')) {
if (manifestJsonFile.domainNamesToIgnoreCertificateErrors.length > 0) {
console.log(`SSL/TLS certificate errors will be ignored for ${manifestJsonFile.domainNamesToIgnoreCertificateErrors.join(', ')}`);

app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
if (shouldIgnoreCertificateForUrl(url)) {
console.log('SSL/TLS certificate error ignored for URL: ' + url);
event.preventDefault()
callback(true)
}
})
}
}

app.on('ready', () => {

// Fix ERR_UNKNOWN_URL_SCHEME using file protocol
Expand Down Expand Up @@ -333,3 +354,15 @@ function getEnvironmentParameter() {

return '';
}

function shouldIgnoreCertificateForUrl(url) {
if (manifestJsonFile.hasOwnProperty('domainNamesToIgnoreCertificateErrors')) {
// Removing the scheme from the url so it will cover https and wss://
const urlWithoutScheme = url.replace(/(^\w+:|^)\/\//, '');
const sites = manifestJsonFile.domainNamesToIgnoreCertificateErrors.filter((oneSite) => urlWithoutScheme.startsWith(oneSite));

return sites.length > 0;
}

return false;
}