Allow ignoring certificate errors #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certificate for https communication with the AspCore backend. We can ignore all cert errors or only cert errors from specific domain names configured in electron.manifest.json
Closed
danatcofo
reviewed
Dec 7, 2021
ElectronNET.Host/main.js
Outdated
| // Bypass SSL/TLS certificate errors only for the domain names specified in the electron.manifest.json file. | ||
| if (manifestJsonFile.hasOwnProperty('domainNamesToIgnoreCertificateErrors')) { | ||
| if (manifestJsonFile.domainNamesToIgnoreCertificateErrors.length > 0) { | ||
| manifestJsonFile.domainNamesToIgnoreCertificateErrors.forEach(function (site) { |
There was a problem hiding this comment.
This can be reduced to a single log file
console.log(`SSL/TLS certificate errors will be ignored for ${manifestJsonFile.domainNamesToIgnoreCertificateErrors.join(', ')}`);There was a problem hiding this comment.
Nice! I made the change. Thanks
… will be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Electron app fails when using a self-signed certificate for https communications with its ASP.NET Core backend. The native electron framework allows to ignore or bypass certificate errors. I am exposing this feature to Electron.NET
There will be two ways to bypass certificate errors:
By adding this flag to the electron.manifest.json file:
"ignoreAllCertificateErrors": trueit will allow to ignore all cert errors. This option is less secureBy adding a list of domain names that we want to ignore certificate errors for in the electron.manifest.json file: