Skip to content

Fix undefined behavior in jofilter_index_impl.h #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined behavior in jofilter_index_impl.h #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/json/jofilter_index_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ double JOFilterTreeIndex<CostModel, TreeIndex>::jedi_k(const TreeIndex& t1,
for (int x = 1; x <= t1_input_size; ++x) {
// Get postorder number from favorable child order number.
i = t1.postl_to_favorder_[x-1] + 1;
p_i = t1.postl_to_height_[t1.postl_to_parent_[i-1]];

// Iterate for all j in the threshold range of i.
j_start = i - threshold;
Expand Down Expand Up @@ -173,6 +172,7 @@ double JOFilterTreeIndex<CostModel, TreeIndex>::jedi_k(const TreeIndex& t1,

// Do not compute for the parent of the root node in T1.
if (i != t1_input_size) {
p_i = t1.postl_to_height_[t1.postl_to_parent_[i-1]];
// Case 1: i is favorable child of parent.
if (t1.postl_to_fav_child_[t1.postl_to_parent_[i-1]] == i-1) {
// Store distances for favorable child used to fill the edit distance matrix later on.
Expand Down Expand Up @@ -215,6 +215,7 @@ double JOFilterTreeIndex<CostModel, TreeIndex>::jedi_k(const TreeIndex& t1,
}
// Case 3: t[i] is the left sibling of the favorable child.
if (i != t1_input_size) {
p_i = t1.postl_to_height_[t1.postl_to_parent_[i-1]];
if (t1.postl_to_left_fav_child_[t1.postl_to_parent_[i-1]] == i-1) {
fav_child_postid = t1.postl_to_fav_child_[t1.postl_to_parent_[i-1]]+1;

Expand Down