Check branch name format when back-porting PR #9127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
tag: no release notes
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the backport script by enforcing a strict patch release name format.
- Replaces the old
release/prefix check with a regex ensuringvMAJOR.MINOR.xpattern. - Updates the error message to reference the new format requirement.
Comments suppressed due to low confidence (1)
tooling/backport-pr-to-patch-release.sh:25
- Consider adding automated tests for this new validation logic to verify both valid and invalid patch release names are handled correctly.
if [[ ! "$PATCH_RELEASE_NAME" =~ ^v[0-9]+\.[0-9]+\.x$ ]]; then
| echo "Patch release name should not be the same as the release branch name. Only include the release name without patch number. (e.g. v1.2.x)" | ||
| # Check patch release name format: | ||
| if [[ ! "$PATCH_RELEASE_NAME" =~ ^v[0-9]+\.[0-9]+\.x$ ]]; then | ||
| echo "Patch release name should be in the format v1.2.x" |
There was a problem hiding this comment.
Improve the error message by including the invalid input and sending it to stderr, for example: echo "Invalid patch release name '$PATCH_RELEASE_NAME'; expected format vMAJOR.MINOR.x." >&2.
Suggested change
| echo "Patch release name should be in the format v1.2.x" | |
| echo "Invalid patch release name '$PATCH_RELEASE_NAME'; expected format vMAJOR.MINOR.x." >&2 |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (993.451 ms) : 0, 993451
Total [baseline] (8.552 s) : 0, 8552372
Agent [candidate] (995.402 ms) : 0, 995402
Total [candidate] (8.539 s) : 0, 8539351
section iast
Agent [baseline] (1.137 s) : 0, 1136633
Total [baseline] (9.286 s) : 0, 9285786
Agent [candidate] (1.131 s) : 0, 1130850
Total [candidate] (9.279 s) : 0, 9279201
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.868 ms) : 0, 685868
BytebuddyAgent [candidate] (687.317 ms) : 0, 687317
GlobalTracer [baseline] (241.632 ms) : 0, 241632
GlobalTracer [candidate] (242.157 ms) : 0, 242157
AppSec [baseline] (30.366 ms) : 0, 30366
AppSec [candidate] (30.275 ms) : 0, 30275
Debugger [baseline] (5.99 ms) : 0, 5990
Debugger [candidate] (6.056 ms) : 0, 6056
Remote Config [baseline] (675.564 µs) : 0, 676
Remote Config [candidate] (671.298 µs) : 0, 671
Telemetry [baseline] (8.227 ms) : 0, 8227
Telemetry [candidate] (8.206 ms) : 0, 8206
section iast
BytebuddyAgent [baseline] (810.303 ms) : 0, 810303
BytebuddyAgent [candidate] (806.752 ms) : 0, 806752
GlobalTracer [baseline] (233.023 ms) : 0, 233023
GlobalTracer [candidate] (231.755 ms) : 0, 231755
AppSec [baseline] (29.957 ms) : 0, 29957
AppSec [candidate] (28.613 ms) : 0, 28613
Debugger [baseline] (7.465 ms) : 0, 7465
Debugger [candidate] (6.64 ms) : 0, 6640
Remote Config [baseline] (589.243 µs) : 0, 589
Remote Config [candidate] (594.562 µs) : 0, 595
Telemetry [baseline] (8.05 ms) : 0, 8050
Telemetry [candidate] (7.941 ms) : 0, 7941
IAST [baseline] (26.461 ms) : 0, 26461
IAST [candidate] (27.873 ms) : 0, 27873
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.72 ms) : 0, 995720
Total [baseline] (10.635 s) : 0, 10635196
Agent [candidate] (995.342 ms) : 0, 995342
Total [candidate] (10.602 s) : 0, 10602352
section appsec
Agent [baseline] (1.176 s) : 0, 1176433
Total [baseline] (10.763 s) : 0, 10763200
Agent [candidate] (1.176 s) : 0, 1175992
Total [candidate] (10.853 s) : 0, 10852628
section iast
Agent [baseline] (1.128 s) : 0, 1128001
Total [baseline] (10.837 s) : 0, 10837387
Agent [candidate] (1.14 s) : 0, 1139514
Total [candidate] (10.803 s) : 0, 10803229
section profiling
Agent [baseline] (1.258 s) : 0, 1257655
Total [baseline] (11.011 s) : 0, 11010679
Agent [candidate] (1.254 s) : 0, 1254373
Total [candidate] (11.021 s) : 0, 11020908
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.391 ms) : 0, 687391
BytebuddyAgent [candidate] (686.856 ms) : 0, 686856
GlobalTracer [baseline] (242.11 ms) : 0, 242110
GlobalTracer [candidate] (242.511 ms) : 0, 242511
AppSec [baseline] (30.454 ms) : 0, 30454
AppSec [candidate] (30.18 ms) : 0, 30180
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (686.68 µs) : 0, 687
Remote Config [candidate] (685.944 µs) : 0, 686
Telemetry [baseline] (8.238 ms) : 0, 8238
Telemetry [candidate] (8.256 ms) : 0, 8256
section appsec
BytebuddyAgent [baseline] (711.24 ms) : 0, 711240
BytebuddyAgent [candidate] (710.903 ms) : 0, 710903
GlobalTracer [baseline] (235.642 ms) : 0, 235642
GlobalTracer [candidate] (235.804 ms) : 0, 235804
AppSec [baseline] (171.262 ms) : 0, 171262
AppSec [candidate] (170.807 ms) : 0, 170807
Debugger [baseline] (5.655 ms) : 0, 5655
Debugger [candidate] (5.748 ms) : 0, 5748
Remote Config [baseline] (592.617 µs) : 0, 593
Remote Config [candidate] (594.468 µs) : 0, 594
Telemetry [baseline] (8.021 ms) : 0, 8021
Telemetry [candidate] (8.009 ms) : 0, 8009
IAST [baseline] (23.213 ms) : 0, 23213
IAST [candidate] (23.307 ms) : 0, 23307
section iast
BytebuddyAgent [baseline] (804.878 ms) : 0, 804878
BytebuddyAgent [candidate] (812.999 ms) : 0, 812999
GlobalTracer [baseline] (231.054 ms) : 0, 231054
GlobalTracer [candidate] (233.648 ms) : 0, 233648
AppSec [baseline] (27.886 ms) : 0, 27886
AppSec [candidate] (26.549 ms) : 0, 26549
Debugger [baseline] (5.744 ms) : 0, 5744
Debugger [candidate] (5.873 ms) : 0, 5873
Remote Config [baseline] (576.122 µs) : 0, 576
Remote Config [candidate] (590.993 µs) : 0, 591
Telemetry [baseline] (7.894 ms) : 0, 7894
Telemetry [candidate] (7.965 ms) : 0, 7965
IAST [baseline] (29.315 ms) : 0, 29315
IAST [candidate] (30.311 ms) : 0, 30311
section profiling
BytebuddyAgent [baseline] (684.385 ms) : 0, 684385
BytebuddyAgent [candidate] (684.046 ms) : 0, 684046
GlobalTracer [baseline] (364.759 ms) : 0, 364759
GlobalTracer [candidate] (363.479 ms) : 0, 363479
AppSec [baseline] (33.604 ms) : 0, 33604
AppSec [candidate] (33.969 ms) : 0, 33969
Debugger [baseline] (9.948 ms) : 0, 9948
Debugger [candidate] (10.011 ms) : 0, 10011
Remote Config [baseline] (681.978 µs) : 0, 682
Remote Config [candidate] (680.792 µs) : 0, 681
Telemetry [baseline] (9.589 ms) : 0, 9589
Telemetry [candidate] (8.849 ms) : 0, 8849
ProfilingAgent [baseline] (105.637 ms) : 0, 105637
ProfilingAgent [candidate] (104.542 ms) : 0, 104542
Profiling [baseline] (105.661 ms) : 0, 105661
Profiling [candidate] (104.566 ms) : 0, 104566
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (36.139 ms) : 35853, 36425
. : milestone, 36139,
appsec (48.732 ms) : 48292, 49172
. : milestone, 48732,
code_origins (47.483 ms) : 47079, 47887
. : milestone, 47483,
iast (43.894 ms) : 43509, 44279
. : milestone, 43894,
profiling (50.107 ms) : 49612, 50602
. : milestone, 50107,
tracing (45.326 ms) : 44945, 45707
. : milestone, 45326,
section candidate
no_agent (36.888 ms) : 36588, 37189
. : milestone, 36888,
appsec (49.599 ms) : 49165, 50032
. : milestone, 49599,
code_origins (45.7 ms) : 45312, 46088
. : milestone, 45700,
iast (44.468 ms) : 44080, 44857
. : milestone, 44468,
profiling (48.76 ms) : 48307, 49212
. : milestone, 48760,
tracing (43.862 ms) : 43495, 44229
. : milestone, 43862,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (4.449 ms) : 4392, 4507
. : milestone, 4449,
iast (9.178 ms) : 9020, 9335
. : milestone, 9178,
iast_FULL (14.111 ms) : 13832, 14390
. : milestone, 14111,
iast_GLOBAL (10.448 ms) : 10265, 10631
. : milestone, 10448,
profiling (8.858 ms) : 8716, 9001
. : milestone, 8858,
tracing (7.754 ms) : 7645, 7863
. : milestone, 7754,
section candidate
no_agent (4.554 ms) : 4502, 4607
. : milestone, 4554,
iast (9.4 ms) : 9244, 9557
. : milestone, 9400,
iast_FULL (13.821 ms) : 13550, 14091
. : milestone, 13821,
iast_GLOBAL (10.108 ms) : 9931, 10284
. : milestone, 10108,
profiling (8.806 ms) : 8656, 8955
. : milestone, 8806,
tracing (7.623 ms) : 7504, 7741
. : milestone, 7623,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.408 ms) : 2358, 2457
. : milestone, 2408,
iast (2.199 ms) : 2136, 2261
. : milestone, 2199,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.019 ms) : 1970, 2068
. : milestone, 2019,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.405 ms) : 2355, 2455
. : milestone, 2405,
iast (2.193 ms) : 2131, 2255
. : milestone, 2193,
iast_GLOBAL (2.233 ms) : 2170, 2296
. : milestone, 2233,
profiling (2.06 ms) : 2008, 2111
. : milestone, 2060,
tracing (2.008 ms) : 1960, 2057
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~601f785499, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
iast (18.293 s) : 18293000, 18293000
. : milestone, 18293000,
iast_GLOBAL (18.103 s) : 18103000, 18103000
. : milestone, 18103000,
profiling (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
tracing (14.774 s) : 14774000, 14774000
. : milestone, 14774000,
section candidate
no_agent (15.309 s) : 15309000, 15309000
. : milestone, 15309000,
appsec (14.571 s) : 14571000, 14571000
. : milestone, 14571000,
iast (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
iast_GLOBAL (18.002 s) : 18002000, 18002000
. : milestone, 18002000,
profiling (15.576 s) : 15576000, 15576000
. : milestone, 15576000,
tracing (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
|
sarahchen6
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR validates the release argument from the back-porting script.
Motivation
Additional Notes
Follow up of #9053 (comment)
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]