Update Backport Script to not Accept Release Branch Name as Patch Release Name #9053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
added
type: enhancement
sarahchen6
approved these changes
Jun 27, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.004 ms) : 0, 997004
Total [baseline] (10.623 s) : 0, 10622986
Agent [candidate] (993.073 ms) : 0, 993073
Total [candidate] (10.541 s) : 0, 10541228
section appsec
Agent [baseline] (1.182 s) : 0, 1181906
Total [baseline] (10.697 s) : 0, 10696649
Agent [candidate] (1.178 s) : 0, 1177601
Total [candidate] (10.724 s) : 0, 10724197
section iast
Agent [baseline] (1.142 s) : 0, 1141945
Total [baseline] (10.789 s) : 0, 10789269
Agent [candidate] (1.138 s) : 0, 1137603
Total [candidate] (10.805 s) : 0, 10805256
section profiling
Agent [baseline] (1.263 s) : 0, 1263463
Total [baseline] (11.013 s) : 0, 11013298
Agent [candidate] (1.241 s) : 0, 1241085
Total [candidate] (10.96 s) : 0, 10960089
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.558 ms) : 0, 688558
BytebuddyAgent [candidate] (686.09 ms) : 0, 686090
GlobalTracer [baseline] (242.391 ms) : 0, 242391
GlobalTracer [candidate] (241.26 ms) : 0, 241260
AppSec [baseline] (30.31 ms) : 0, 30310
AppSec [candidate] (30.096 ms) : 0, 30096
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.014 ms) : 0, 6014
Remote Config [baseline] (671.458 µs) : 0, 671
Remote Config [candidate] (674.757 µs) : 0, 675
Telemetry [baseline] (8.167 ms) : 0, 8167
Telemetry [candidate] (8.16 ms) : 0, 8160
section appsec
BytebuddyAgent [baseline] (715.837 ms) : 0, 715837
BytebuddyAgent [candidate] (711.783 ms) : 0, 711783
GlobalTracer [baseline] (236.305 ms) : 0, 236305
GlobalTracer [candidate] (235.781 ms) : 0, 235781
AppSec [baseline] (171.057 ms) : 0, 171057
AppSec [candidate] (171.539 ms) : 0, 171539
Debugger [baseline] (5.739 ms) : 0, 5739
Debugger [candidate] (5.74 ms) : 0, 5740
Remote Config [baseline] (613.877 µs) : 0, 614
Remote Config [candidate] (592.916 µs) : 0, 593
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.108 ms) : 0, 8108
IAST [baseline] (23.387 ms) : 0, 23387
IAST [candidate] (23.18 ms) : 0, 23180
section iast
BytebuddyAgent [baseline] (814.614 ms) : 0, 814614
BytebuddyAgent [candidate] (812.556 ms) : 0, 812556
GlobalTracer [baseline] (234.377 ms) : 0, 234377
GlobalTracer [candidate] (232.415 ms) : 0, 232415
AppSec [baseline] (27.152 ms) : 0, 27152
AppSec [candidate] (31.343 ms) : 0, 31343
Debugger [baseline] (5.864 ms) : 0, 5864
Debugger [candidate] (5.853 ms) : 0, 5853
Remote Config [baseline] (583.689 µs) : 0, 584
Remote Config [candidate] (583.455 µs) : 0, 583
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.032 ms) : 0, 8032
IAST [baseline] (29.641 ms) : 0, 29641
IAST [candidate] (25.994 ms) : 0, 25994
section profiling
BytebuddyAgent [baseline] (686.894 ms) : 0, 686894
BytebuddyAgent [candidate] (676.465 ms) : 0, 676465
GlobalTracer [baseline] (366.701 ms) : 0, 366701
GlobalTracer [candidate] (360.009 ms) : 0, 360009
AppSec [baseline] (34.592 ms) : 0, 34592
AppSec [candidate] (30.86 ms) : 0, 30860
Debugger [baseline] (8.508 ms) : 0, 8508
Debugger [candidate] (11.332 ms) : 0, 11332
Remote Config [baseline] (673.925 µs) : 0, 674
Remote Config [candidate] (654.553 µs) : 0, 655
Telemetry [baseline] (9.662 ms) : 0, 9662
Telemetry [candidate] (10.181 ms) : 0, 10181
ProfilingAgent [baseline] (107.37 ms) : 0, 107370
ProfilingAgent [candidate] (103.174 ms) : 0, 103174
Profiling [baseline] (107.394 ms) : 0, 107394
Profiling [candidate] (103.198 ms) : 0, 103198
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (992.898 ms) : 0, 992898
Total [baseline] (8.535 s) : 0, 8534544
Agent [candidate] (993.77 ms) : 0, 993770
Total [candidate] (8.548 s) : 0, 8548313
section iast
Agent [baseline] (1.132 s) : 0, 1131735
Total [baseline] (9.237 s) : 0, 9237379
Agent [candidate] (1.133 s) : 0, 1132747
Total [candidate] (9.3 s) : 0, 9299866
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.96 ms) : 0, 685960
BytebuddyAgent [candidate] (686.558 ms) : 0, 686558
GlobalTracer [baseline] (241.245 ms) : 0, 241245
GlobalTracer [candidate] (241.457 ms) : 0, 241457
AppSec [baseline] (30.083 ms) : 0, 30083
AppSec [candidate] (30.088 ms) : 0, 30088
Debugger [baseline] (6.013 ms) : 0, 6013
Debugger [candidate] (6.047 ms) : 0, 6047
Remote Config [baseline] (675.964 µs) : 0, 676
Remote Config [candidate] (691.967 µs) : 0, 692
Telemetry [baseline] (8.195 ms) : 0, 8195
Telemetry [candidate] (8.171 ms) : 0, 8171
section iast
BytebuddyAgent [baseline] (806.525 ms) : 0, 806525
BytebuddyAgent [candidate] (807.453 ms) : 0, 807453
GlobalTracer [baseline] (232.865 ms) : 0, 232865
GlobalTracer [candidate] (232.777 ms) : 0, 232777
AppSec [baseline] (29.344 ms) : 0, 29344
AppSec [candidate] (28.778 ms) : 0, 28778
Debugger [baseline] (5.834 ms) : 0, 5834
Debugger [candidate] (6.733 ms) : 0, 6733
Remote Config [baseline] (584.26 µs) : 0, 584
Remote Config [candidate] (570.856 µs) : 0, 571
Telemetry [baseline] (8.035 ms) : 0, 8035
Telemetry [candidate] (7.912 ms) : 0, 7912
IAST [baseline] (27.775 ms) : 0, 27775
IAST [candidate] (27.746 ms) : 0, 27746
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section baseline
no_agent (4.269 ms) : 4222, 4315
. : milestone, 4269,
iast (9.32 ms) : 9170, 9469
. : milestone, 9320,
iast_FULL (14.006 ms) : 13731, 14281
. : milestone, 14006,
iast_GLOBAL (10.263 ms) : 10083, 10442
. : milestone, 10263,
profiling (8.63 ms) : 8496, 8765
. : milestone, 8630,
tracing (7.659 ms) : 7544, 7774
. : milestone, 7659,
section candidate
no_agent (4.465 ms) : 4415, 4516
. : milestone, 4465,
iast (9.377 ms) : 9221, 9533
. : milestone, 9377,
iast_FULL (14.39 ms) : 14105, 14676
. : milestone, 14390,
iast_GLOBAL (9.868 ms) : 9697, 10039
. : milestone, 9868,
profiling (9.275 ms) : 9124, 9425
. : milestone, 9275,
tracing (7.84 ms) : 7721, 7959
. : milestone, 7840,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section baseline
no_agent (36.825 ms) : 36524, 37126
. : milestone, 36825,
appsec (49.718 ms) : 49263, 50173
. : milestone, 49718,
code_origins (44.724 ms) : 44334, 45114
. : milestone, 44724,
iast (44.737 ms) : 44341, 45132
. : milestone, 44737,
profiling (47.133 ms) : 46670, 47596
. : milestone, 47133,
tracing (44.955 ms) : 44578, 45331
. : milestone, 44955,
section candidate
no_agent (36.725 ms) : 36422, 37027
. : milestone, 36725,
appsec (48.203 ms) : 47770, 48635
. : milestone, 48203,
code_origins (44.591 ms) : 44203, 44979
. : milestone, 44591,
iast (44.044 ms) : 43658, 44429
. : milestone, 44044,
profiling (47.864 ms) : 47435, 48293
. : milestone, 47864,
tracing (43.187 ms) : 42842, 43532
. : milestone, 43187,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.411 ms) : 2362, 2460
. : milestone, 2411,
iast (2.197 ms) : 2135, 2259
. : milestone, 2197,
iast_GLOBAL (2.236 ms) : 2174, 2298
. : milestone, 2236,
profiling (2.06 ms) : 2009, 2111
. : milestone, 2060,
tracing (2.01 ms) : 1962, 2058
. : milestone, 2010,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.41 ms) : 2361, 2459
. : milestone, 2410,
iast (2.2 ms) : 2138, 2263
. : milestone, 2200,
iast_GLOBAL (2.241 ms) : 2178, 2303
. : milestone, 2241,
profiling (2.511 ms) : 2336, 2685
. : milestone, 2511,
tracing (2.011 ms) : 1963, 2059
. : milestone, 2011,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d84e32ec70, baseline=1.51.0-SNAPSHOT~2ee59a972d
dateFormat X
axisFormat %s
section baseline
no_agent (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
appsec (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
iast (18.608 s) : 18608000, 18608000
. : milestone, 18608000,
iast_GLOBAL (18.261 s) : 18261000, 18261000
. : milestone, 18261000,
profiling (15.659 s) : 15659000, 15659000
. : milestone, 15659000,
tracing (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
section candidate
no_agent (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
appsec (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
iast (18.233 s) : 18233000, 18233000
. : milestone, 18233000,
iast_GLOBAL (17.759 s) : 17759000, 17759000
. : milestone, 17759000,
profiling (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
tracing (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
|
Comment on lines
+25
to
+27
| if [[ "$PATCH_RELEASE_NAME" =~ ^release/.* ]]; then | ||
| echo "Patch release name should not be the same as the release branch name. Only include the release name without patch number. (e.g. v1.2.x)" | ||
| exit 1 |
There was a problem hiding this comment.
If you're enforcing the patch release name to be in the v1.2.x format, you should test it then.
Bash can do regexp testing 😉
There was a problem hiding this comment.
I tested this locally, trying to backport a PR with PATCH_RELEASE_NAME=release/1.50.2 and it got caught in the proper check. On the contrary, doing PATCH_RELEASE_NAME=1.50.2 skips that check.
@PerfectSlayer Is this what you mean by testing the regexp testing?
There was a problem hiding this comment.
No, I meant you should test that the arg is following the ^v[0-9]\.....$ pattern.
I made #9127 as follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Currently the backport script expects that the
PATCH_RELEASE_NAMEis prefixed withrelease/. This does not make sense because thePATCH_RELEASE_BRANCHis defined asrelease/$PATCH_RELEASE_NAME, which could potentially lead to branch names such asrelease/release/v1.50.x. This PR removes the check to ensure thatPATCH_RELEASE_NAMEis prefixed withrelease/(since the variable is no longer used afterwards), and actually enforces that it does not start with that prefix to avoid therelease/release/v.1.50.xscenario.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]