Skip to content

Rename test methods to remove duplicate method names #8796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Rename test methods to remove duplicate method names #8796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dd-java-agent/instrumentation/java-security/src/test/groovy/test/WeakCipherTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class WeakCipherTest extends AgentTestRunner {
}

// Key Generator
def "test weak cipher instrumentation"() {
def "test weak keygen instrumentation"() {
setup:
WeakCipherModule module = Mock(WeakCipherModule)
InstrumentationBridge.registerIastModule(module)
Expand All @@ -75,7 +75,7 @@ class WeakCipherTest extends AgentTestRunner {
1 * module.onCipherAlgorithm(_)
}

def "test weak cipher instrumentation with provider"() {
def "test weak keygen instrumentation with provider"() {
setup:
WeakCipherModule module = Mock(WeakCipherModule)
InstrumentationBridge.registerIastModule(module)
Expand All @@ -88,7 +88,7 @@ class WeakCipherTest extends AgentTestRunner {
1 * module.onCipherAlgorithm(_)
}

def "test weak cipher instrumentation with provider string"() {
def "test weak keygen instrumentation with provider string"() {
setup:
WeakCipherModule module = Mock(WeakCipherModule)
InstrumentationBridge.registerIastModule(module)
Expand Down
2 changes: 1 addition & 1 deletion dd-trace-core/src/test/groovy/datadog/trace/common/sampling/SamplerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class SamplerTest extends DDSpecification{
!(sampler instanceof AsmStandaloneSampler)
}

void "test that AsmStandaloneSampler is not selected when apm tracing and asm not enabled"() {
void "test that AsmStandaloneSampler is not selected when apm tracing enabled and asm not enabled"() {
setup:
Config config = new Config()

Expand Down
2 changes: 1 addition & 1 deletion dd-trace-core/src/test/groovy/datadog/trace/common/writer/PrioritizationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class PrioritizationTest extends DDSpecification {
[] | USER_KEEP | 1 | 0 | ENQUEUED_FOR_SERIALIZATION
}

def "drop strategy respects force keep" () {
def "span sampling drop strategy respects force keep" () {
setup:
Queue<Object> primary = Mock(Queue)
Queue<Object> spanSampling = Mock(Queue)
Expand Down
2 changes: 1 addition & 1 deletion telemetry/src/test/groovy/datadog/telemetry/TelemetryRouterSpecification.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ class TelemetryRouterSpecification extends Specification {
500 | null | agentTelemetryUrl
}

def 'switch to Intake when Agent fails to receive telemetry requests'() {
def 'switch to Intake then back to Agent when both fail to receive telemetry requests'() {
Request request

when:
Expand Down