Skip to content

Rename test methods to remove duplicate method names #8796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Rename test methods to remove duplicate method names #8796

merged 1 commit into from
May 12, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented May 11, 2025 •
edited
Loading

Motivation

Observed when doing some testing locally - gradle only seems to notice when you add/remove a test class in the same module which I assume causes it to do a full compile (see https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/jobs/932703279)

Quick scan using grep revealed the following duplicates per test file:

      2 dd-java-agent/instrumentation/java-security/src/test/groovy/test/WeakCipherTest.groovy:  def "test weak cipher instrumentation with provider string"() {
      2 dd-java-agent/instrumentation/java-security/src/test/groovy/test/WeakCipherTest.groovy:  def "test weak cipher instrumentation with provider"() {
      2 dd-java-agent/instrumentation/java-security/src/test/groovy/test/WeakCipherTest.groovy:  def "test weak cipher instrumentation"() {
      2 dd-trace-core/src/test/groovy/datadog/trace/common/writer/PrioritizationTest.groovy:  def "drop strategy respects force keep" () {
      2 telemetry/src/test/groovy/datadog/telemetry/TelemetryRouterSpecification.groovy:  def "switch to Intake when Agent fails to receive telemetry requests"() {

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added type: bug Bug report and fix comp: core Tracer core tag: no release notes Changes to exclude from release notes labels May 11, 2025
@mcculls mcculls changed the title Fix compilation errors observed using ./gradlew :dd-trace-core:test locally Fix test compilation errors observed due to duplicate test method names May 11, 2025
@mcculls mcculls changed the title Fix test compilation errors observed due to duplicate test method names Rename test methods to remove duplicate method names May 11, 2025
@mcculls mcculls force-pushed the mcculls/avoid-duplicate-test-method-names branch from cbcb1d0 to 52c16bf Compare May 11, 2025 17:40
@pr-commenter
Copy link

pr-commenter bot commented May 11, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-duplicate-test-method-names
git_commit_date 1746825821 1746985945
git_commit_sha f494c33 2c16bf3635
release_version 1.50.0-SNAPSHOT~f494c33b01 1.50.0-SNAPSHOT~52c16bf3635
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1746987799 1746987799
ci_job_id 932708543 932708543
ci_pipeline_id 64732633 64732633
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-i83qnnyx-project-304-concurrent-0-cv3yoek8 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-i83qnnyx-project-304-concurrent-0-cv3yoek8 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1038545
Total [baseline] (8.68 s) : 0, 8679891
Agent [candidate] (1.026 s) : 0, 1025805
Total [candidate] (8.676 s) : 0, 8676455
section iast
Agent [baseline] (1.165 s) : 0, 1164878
Total [baseline] (9.305 s) : 0, 9304993
Agent [candidate] (1.151 s) : 0, 1150584
Total [candidate] (9.248 s) : 0, 9248470
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.147 s) : 0, 1146961
Total [baseline] (9.19 s) : 0, 9190031
Agent [candidate] (1.154 s) : 0, 1153693
Total [candidate] (9.242 s) : 0, 9242300
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1151830
Total [baseline] (9.226 s) : 0, 9225780
Agent [candidate] (1.155 s) : 0, 1154920
Total [candidate] (9.25 s) : 0, 9250417
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.165 s 126.333 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.147 s 108.416 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.152 s 113.285 ms (10.9%)
Total tracing 8.68 s -
Total iast 9.305 s 625.102 ms (7.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.19 s 510.14 ms (5.9%)
Total iast_TELEMETRY_OFF 9.226 s 545.889 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.026 s -
Agent iast 1.151 s 124.78 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.154 s 127.888 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.155 s 129.116 ms (12.6%)
Total tracing 8.676 s -
Total iast 9.248 s 572.015 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.242 s 565.845 ms (6.5%)
Total iast_TELEMETRY_OFF 9.25 s 573.963 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.603 ms) : 0, 694603
BytebuddyAgent [candidate] (685.182 ms) : 0, 685182
GlobalTracer [baseline] (243.845 ms) : 0, 243845
GlobalTracer [candidate] (241.457 ms) : 0, 241457
AppSec [baseline] (56.951 ms) : 0, 56951
AppSec [candidate] (56.723 ms) : 0, 56723
Debugger [baseline] (7.73 ms) : 0, 7730
Debugger [candidate] (9.138 ms) : 0, 9138
Remote Config [baseline] (709.496 µs) : 0, 709
Remote Config [candidate] (685.341 µs) : 0, 685
Telemetry [baseline] (10.647 ms) : 0, 10647
Telemetry [candidate] (9.044 ms) : 0, 9044
section iast
BytebuddyAgent [baseline] (814.587 ms) : 0, 814587
BytebuddyAgent [candidate] (802.685 ms) : 0, 802685
GlobalTracer [baseline] (232.83 ms) : 0, 232830
GlobalTracer [candidate] (230.938 ms) : 0, 230938
IAST [baseline] (30.264 ms) : 0, 30264
IAST [candidate] (27.704 ms) : 0, 27704
AppSec [baseline] (48.939 ms) : 0, 48939
AppSec [candidate] (51.308 ms) : 0, 51308
Debugger [baseline] (5.929 ms) : 0, 5929
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (595.113 µs) : 0, 595
Remote Config [candidate] (623.308 µs) : 0, 623
Telemetry [baseline] (7.925 ms) : 0, 7925
Telemetry [candidate] (7.914 ms) : 0, 7914
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.345 ms) : 0, 800345
BytebuddyAgent [candidate] (803.732 ms) : 0, 803732
GlobalTracer [baseline] (230.368 ms) : 0, 230368
GlobalTracer [candidate] (232.554 ms) : 0, 232554
IAST [baseline] (29.012 ms) : 0, 29012
IAST [candidate] (28.753 ms) : 0, 28753
AppSec [baseline] (49.304 ms) : 0, 49304
AppSec [candidate] (50.594 ms) : 0, 50594
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.963 ms) : 0, 5963
Remote Config [baseline] (590.456 µs) : 0, 590
Remote Config [candidate] (588.675 µs) : 0, 589
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.979 ms) : 0, 7979
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.868 ms) : 0, 804868
BytebuddyAgent [candidate] (806.399 ms) : 0, 806399
GlobalTracer [baseline] (230.992 ms) : 0, 230992
GlobalTracer [candidate] (232.256 ms) : 0, 232256
IAST [baseline] (23.077 ms) : 0, 23077
IAST [candidate] (23.307 ms) : 0, 23307
AppSec [baseline] (54.96 ms) : 0, 54960
AppSec [candidate] (54.851 ms) : 0, 54851
Debugger [baseline] (5.906 ms) : 0, 5906
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (590.265 µs) : 0, 590
Remote Config [candidate] (611.045 µs) : 0, 611
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (7.841 ms) : 0, 7841
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029856
Total [baseline] (10.575 s) : 0, 10575069
Agent [candidate] (1.035 s) : 0, 1035237
Total [candidate] (10.519 s) : 0, 10518650
section appsec
Agent [baseline] (1.165 s) : 0, 1165134
Total [baseline] (10.77 s) : 0, 10770439
Agent [candidate] (1.164 s) : 0, 1163594
Total [candidate] (10.681 s) : 0, 10680805
section iast
Agent [baseline] (1.161 s) : 0, 1160568
Total [baseline] (10.973 s) : 0, 10972811
Agent [candidate] (1.153 s) : 0, 1152813
Total [candidate] (10.936 s) : 0, 10936209
section profiling
Agent [baseline] (1.285 s) : 0, 1285251
Total [baseline] (10.912 s) : 0, 10911770
Agent [candidate] (1.286 s) : 0, 1285730
Total [candidate] (10.987 s) : 0, 10987445
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.03 s -
Agent appsec 1.165 s 135.278 ms (13.1%)
Agent iast 1.161 s 130.712 ms (12.7%)
Agent profiling 1.285 s 255.395 ms (24.8%)
Total tracing 10.575 s -
Total appsec 10.77 s 195.37 ms (1.8%)
Total iast 10.973 s 397.742 ms (3.8%)
Total profiling 10.912 s 336.702 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent appsec 1.164 s 128.357 ms (12.4%)
Agent iast 1.153 s 117.576 ms (11.4%)
Agent profiling 1.286 s 250.493 ms (24.2%)
Total tracing 10.519 s -
Total appsec 10.681 s 162.155 ms (1.5%)
Total iast 10.936 s 417.559 ms (4.0%)
Total profiling 10.987 s 468.796 ms (4.5%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.168 ms) : 0, 689168
BytebuddyAgent [candidate] (693.611 ms) : 0, 693611
GlobalTracer [baseline] (242.169 ms) : 0, 242169
GlobalTracer [candidate] (243.472 ms) : 0, 243472
AppSec [baseline] (54.876 ms) : 0, 54876
AppSec [candidate] (55.081 ms) : 0, 55081
Debugger [baseline] (9.296 ms) : 0, 9296
Debugger [candidate] (8.453 ms) : 0, 8453
Remote Config [baseline] (710.616 µs) : 0, 711
Remote Config [candidate] (724.567 µs) : 0, 725
Telemetry [baseline] (9.821 ms) : 0, 9821
Telemetry [candidate] (9.999 ms) : 0, 9999
section appsec
BytebuddyAgent [baseline] (701.912 ms) : 0, 701912
BytebuddyAgent [candidate] (701.797 ms) : 0, 701797
GlobalTracer [baseline] (237.764 ms) : 0, 237764
GlobalTracer [candidate] (237.191 ms) : 0, 237191
AppSec [baseline] (176.696 ms) : 0, 176696
AppSec [candidate] (175.524 ms) : 0, 175524
Debugger [baseline] (5.965 ms) : 0, 5965
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (639.205 µs) : 0, 639
Remote Config [candidate] (631.193 µs) : 0, 631
Telemetry [baseline] (7.756 ms) : 0, 7756
Telemetry [candidate] (8.174 ms) : 0, 8174
IAST [baseline] (21.715 ms) : 0, 21715
IAST [candidate] (21.61 ms) : 0, 21610
section iast
BytebuddyAgent [baseline] (810.355 ms) : 0, 810355
BytebuddyAgent [candidate] (804.346 ms) : 0, 804346
GlobalTracer [baseline] (232.839 ms) : 0, 232839
GlobalTracer [candidate] (231.11 ms) : 0, 231110
AppSec [baseline] (51.426 ms) : 0, 51426
AppSec [candidate] (50.678 ms) : 0, 50678
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (5.991 ms) : 0, 5991
Remote Config [baseline] (624.308 µs) : 0, 624
Remote Config [candidate] (620.125 µs) : 0, 620
Telemetry [baseline] (7.961 ms) : 0, 7961
Telemetry [candidate] (7.93 ms) : 0, 7930
IAST [baseline] (26.007 ms) : 0, 26007
IAST [candidate] (28.556 ms) : 0, 28556
section profiling
ProfilingAgent [baseline] (109.881 ms) : 0, 109881
ProfilingAgent [candidate] (110.752 ms) : 0, 110752
BytebuddyAgent [baseline] (675.379 ms) : 0, 675379
BytebuddyAgent [candidate] (674.083 ms) : 0, 674083
GlobalTracer [baseline] (379.679 ms) : 0, 379679
GlobalTracer [candidate] (381.075 ms) : 0, 381075
AppSec [baseline] (54.835 ms) : 0, 54835
AppSec [candidate] (54.109 ms) : 0, 54109
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.148 ms) : 0, 6148
Remote Config [baseline] (658.875 µs) : 0, 659
Remote Config [candidate] (671.949 µs) : 0, 672
Telemetry [baseline] (8.123 ms) : 0, 8123
Telemetry [candidate] (8.149 ms) : 0, 8149
Profiling [baseline] (109.907 ms) : 0, 109907
Profiling [candidate] (110.778 ms) : 0, 110778
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-11T17:51:23 2025-05-11T17:59:11
git_branch master mcculls/avoid-duplicate-test-method-names
git_commit_date 1746825821 1746985816
git_commit_sha f494c33 2c16bf3635
release_version 1.50.0-SNAPSHOT~f494c33b01 1.50.0-SNAPSHOT~52c16bf3635
start_time 2025-05-11T17:51:09 2025-05-11T17:58:57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1746986751 1746986751
ci_job_id 932708544 932708544
ci_pipeline_id 64732633 64732633
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-psrqmy6d-project-304-concurrent-0-9sulooca 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-psrqmy6d-project-304-concurrent-0-9sulooca 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.382 ms) : 1363, 1401
.   : milestone, 1382,
appsec (1.741 ms) : 1716, 1765
.   : milestone, 1741,
appsec_no_iast (1.749 ms) : 1726, 1772
.   : milestone, 1749,
code_origins (1.662 ms) : 1635, 1689
.   : milestone, 1662,
iast (1.518 ms) : 1495, 1542
.   : milestone, 1518,
profiling (1.545 ms) : 1520, 1571
.   : milestone, 1545,
tracing (1.503 ms) : 1479, 1527
.   : milestone, 1503,
section candidate
no_agent (1.375 ms) : 1355, 1394
.   : milestone, 1375,
appsec (1.747 ms) : 1723, 1771
.   : milestone, 1747,
appsec_no_iast (1.727 ms) : 1703, 1750
.   : milestone, 1727,
code_origins (1.697 ms) : 1670, 1724
.   : milestone, 1697,
iast (1.552 ms) : 1528, 1576
.   : milestone, 1552,
profiling (1.504 ms) : 1480, 1528
.   : milestone, 1504,
tracing (1.51 ms) : 1487, 1533
.   : milestone, 1510,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.382 ms [1.363 ms, 1.401 ms] -
appsec 1.741 ms [1.716 ms, 1.765 ms] 358.35 µs (25.9%)
appsec_no_iast 1.749 ms [1.726 ms, 1.772 ms] 366.788 µs (26.5%)
code_origins 1.662 ms [1.635 ms, 1.689 ms] 280.158 µs (20.3%)
iast 1.518 ms [1.495 ms, 1.542 ms] 136.139 µs (9.8%)
profiling 1.545 ms [1.52 ms, 1.571 ms] 163.29 µs (11.8%)
tracing 1.503 ms [1.479 ms, 1.527 ms] 120.921 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.375 ms [1.355 ms, 1.394 ms] -
appsec 1.747 ms [1.723 ms, 1.771 ms] 372.289 µs (27.1%)
appsec_no_iast 1.727 ms [1.703 ms, 1.75 ms] 351.972 µs (25.6%)
code_origins 1.697 ms [1.67 ms, 1.724 ms] 322.044 µs (23.4%)
iast 1.552 ms [1.528 ms, 1.576 ms] 177.25 µs (12.9%)
profiling 1.504 ms [1.48 ms, 1.528 ms] 129.371 µs (9.4%)
tracing 1.51 ms [1.487 ms, 1.533 ms] 135.494 µs (9.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01
    dateFormat X
    axisFormat %s
section baseline
no_agent (387.729 µs) : 367, 408
.   : milestone, 388,
iast (524.441 µs) : 501, 548
.   : milestone, 524,
iast_FULL (744.94 µs) : 723, 767
.   : milestone, 745,
iast_GLOBAL (585.214 µs) : 563, 608
.   : milestone, 585,
iast_HARDCODED_SECRET_DISABLED (530.518 µs) : 507, 554
.   : milestone, 531,
iast_INACTIVE (478.51 µs) : 456, 501
.   : milestone, 479,
iast_TELEMETRY_OFF (519.668 µs) : 496, 543
.   : milestone, 520,
tracing (465.881 µs) : 443, 488
.   : milestone, 466,
section candidate
no_agent (384.775 µs) : 364, 406
.   : milestone, 385,
iast (528.41 µs) : 507, 550
.   : milestone, 528,
iast_FULL (737.531 µs) : 715, 760
.   : milestone, 738,
iast_GLOBAL (574.937 µs) : 553, 597
.   : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (522.902 µs) : 501, 545
.   : milestone, 523,
iast_INACTIVE (476.916 µs) : 454, 500
.   : milestone, 477,
iast_TELEMETRY_OFF (501.09 µs) : 478, 524
.   : milestone, 501,
tracing (469.661 µs) : 447, 492
.   : milestone, 470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 387.729 µs [367.298 µs, 408.16 µs] -
iast 524.441 µs [501.33 µs, 547.552 µs] 136.712 µs (35.3%)
iast_FULL 744.94 µs [722.931 µs, 766.95 µs] 357.212 µs (92.1%)
iast_GLOBAL 585.214 µs [562.663 µs, 607.765 µs] 197.486 µs (50.9%)
iast_HARDCODED_SECRET_DISABLED 530.518 µs [507.392 µs, 553.643 µs] 142.789 µs (36.8%)
iast_INACTIVE 478.51 µs [456.076 µs, 500.945 µs] 90.781 µs (23.4%)
iast_TELEMETRY_OFF 519.668 µs [496.111 µs, 543.226 µs] 131.94 µs (34.0%)
tracing 465.881 µs [443.442 µs, 488.32 µs] 78.152 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.775 µs [363.627 µs, 405.923 µs] -
iast 528.41 µs [506.534 µs, 550.286 µs] 143.635 µs (37.3%)
iast_FULL 737.531 µs [715.46 µs, 759.602 µs] 352.756 µs (91.7%)
iast_GLOBAL 574.937 µs [552.837 µs, 597.038 µs] 190.162 µs (49.4%)
iast_HARDCODED_SECRET_DISABLED 522.902 µs [501.126 µs, 544.677 µs] 138.127 µs (35.9%)
iast_INACTIVE 476.916 µs [453.633 µs, 500.199 µs] 92.141 µs (23.9%)
iast_TELEMETRY_OFF 501.09 µs [478.071 µs, 524.109 µs] 116.315 µs (30.2%)
tracing 469.661 µs [447.22 µs, 492.103 µs] 84.886 µs (22.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-duplicate-test-method-names
git_commit_date 1746825821 1746985813
git_commit_sha f494c33 2c16bf3635
release_version 1.50.0-SNAPSHOT~f494c33b01 1.50.0-SNAPSHOT~52c16bf3635
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1746987284 1746987284
ci_job_id 932708545 932708545
ci_pipeline_id 64732633 64732633
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-i83qnnyx-project-304-concurrent-1-7bu7dcpr 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-i83qnnyx-project-304-concurrent-1-7bu7dcpr 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.686 s) : 15686000, 15686000
.   : milestone, 15686000,
appsec (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
iast (19.086 s) : 19086000, 19086000
.   : milestone, 19086000,
iast_GLOBAL (18.074 s) : 18074000, 18074000
.   : milestone, 18074000,
profiling (14.823 s) : 14823000, 14823000
.   : milestone, 14823000,
tracing (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
section candidate
no_agent (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
appsec (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
iast (18.882 s) : 18882000, 18882000
.   : milestone, 18882000,
iast_GLOBAL (18.028 s) : 18028000, 18028000
.   : milestone, 18028000,
profiling (15.849 s) : 15849000, 15849000
.   : milestone, 15849000,
tracing (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.686 s [15.686 s, 15.686 s] -
appsec 15.09 s [15.09 s, 15.09 s] -596.0 ms (-3.8%)
iast 19.086 s [19.086 s, 19.086 s] 3.4 s (21.7%)
iast_GLOBAL 18.074 s [18.074 s, 18.074 s] 2.388 s (15.2%)
profiling 14.823 s [14.823 s, 14.823 s] -863.0 ms (-5.5%)
tracing 14.981 s [14.981 s, 14.981 s] -705.0 ms (-4.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.252 s [15.252 s, 15.252 s] -
appsec 15.252 s [15.252 s, 15.252 s] 0.0 µs (0.0%)
iast 18.882 s [18.882 s, 18.882 s] 3.63 s (23.8%)
iast_GLOBAL 18.028 s [18.028 s, 18.028 s] 2.776 s (18.2%)
profiling 15.849 s [15.849 s, 15.849 s] 597.0 ms (3.9%)
tracing 15.052 s [15.052 s, 15.052 s] -200.0 ms (-1.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~52c16bf3635, baseline=1.50.0-SNAPSHOT~f494c33b01
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.396 ms) : 2347, 2446
.   : milestone, 2396,
iast (2.173 ms) : 2112, 2235
.   : milestone, 2173,
iast_GLOBAL (2.225 ms) : 2163, 2287
.   : milestone, 2225,
profiling (2.517 ms) : 2333, 2700
.   : milestone, 2517,
tracing (2.001 ms) : 1953, 2049
.   : milestone, 2001,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.395 ms) : 2346, 2444
.   : milestone, 2395,
iast (2.178 ms) : 2116, 2240
.   : milestone, 2178,
iast_GLOBAL (2.22 ms) : 2158, 2282
.   : milestone, 2220,
profiling (2.035 ms) : 1985, 2085
.   : milestone, 2035,
tracing (2.0 ms) : 1952, 2047
.   : milestone, 2000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.396 ms [2.347 ms, 2.446 ms] 923.067 µs (62.7%)
iast 2.173 ms [2.112 ms, 2.235 ms] 699.901 µs (47.5%)
iast_GLOBAL 2.225 ms [2.163 ms, 2.287 ms] 751.751 µs (51.0%)
profiling 2.517 ms [2.333 ms, 2.7 ms] 1.043 ms (70.8%)
tracing 2.001 ms [1.953 ms, 2.049 ms] 527.602 µs (35.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.395 ms [2.346 ms, 2.444 ms] 926.671 µs (63.1%)
iast 2.178 ms [2.116 ms, 2.24 ms] 709.49 µs (48.3%)
iast_GLOBAL 2.22 ms [2.158 ms, 2.282 ms] 751.115 µs (51.1%)
profiling 2.035 ms [1.985 ms, 2.085 ms] 566.123 µs (38.5%)
tracing 2.0 ms [1.952 ms, 2.047 ms] 530.852 µs (36.1%)

@mcculls mcculls marked this pull request as ready for review May 11, 2025 17:42
@mcculls mcculls requested review from a team as code owners May 11, 2025 17:42
@mcculls mcculls requested a review from smola May 11, 2025 17:42
@mcculls mcculls mentioned this pull request May 11, 2025
Closed
@mcculls mcculls merged commit 7c9a384 into master May 12, 2025
592 of 593 checks passed
@mcculls mcculls deleted the mcculls/avoid-duplicate-test-method-names branch May 12, 2025 09:22
@github-actions github-actions bot added this to the 1.50.0 milestone May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @amarziali