Skip to content

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Apr 15, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhlidd mhlidd added the tag: do not merge Do not merge changes label Apr 15, 2025
@mhlidd
Copy link
Contributor Author

mhlidd commented Apr 15, 2025

@PerfectSlayer The issue seems to be that there are multiple sets of headers that are being extracted in consecutive calls. Whenever there is a set of headers that come in without any information we can extract (i.e. trace headers, baggage headers, etc) we extract an empty context and attach that to the context scope. That seems to be causing a NPE in the Tomcat instrumentation logging, but I'm not sure where that is happening. I will DM you some logs regarding this.

Seems like I had a small error in setting the context 🤦

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2025

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-14T19:39:12 2025-05-14T19:46:56
git_branch master mhlidd/visibility_baggage_e2e_failing
git_commit_date 1747229243 1747250502
git_commit_sha 7c80dbe aceb45d
release_version 1.50.0-SNAPSHOT~7c80dbede3 1.48.0-SNAPSHOT~aceb45d0c6
start_time 2025-05-14T19:39:01 2025-05-14T19:46:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747252288 1747252288
ci_job_id 938807194 938807194
ci_pipeline_id 65126074 65126074
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xnwlpqwj-project-304-concurrent-0-76sl1e94 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xnwlpqwj-project-304-concurrent-0-76sl1e94 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant no_agent no_agent

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 2 unstable metrics.

Dacapo

@mhlidd mhlidd closed this Apr 22, 2025
@mhlidd mhlidd reopened this May 14, 2025
@mhlidd mhlidd closed this May 20, 2025
@mhlidd mhlidd deleted the mhlidd/visibility_baggage_e2e_failing branch August 14, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: do not merge Do not merge changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant