adding meta support #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
approved these changes
Jul 3, 2017
| httpCon.setRequestProperty("Content-Type", "application/json"); | ||
| httpCon.setRequestProperty("Datadog-Meta-Lang", "java"); | ||
| httpCon.setRequestProperty("Datadog-Meta-Lang-Version", DDTracer.JAVA_VERSION); | ||
| httpCon.setRequestProperty("Datadog-Meta-Tracer-Version", DDTracer.CURRENT_VERSION); |
tylerbenson
reviewed
Jul 3, 2017
| public class DDApi { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(DDApi.class.getName()); | ||
| private static final Logger logger = LoggerFactory.getLogger(DDApi.class.getName()); |
There was a problem hiding this comment.
Looks like formatting changed a lot. Was this intentional? Perhaps we should have a discussion on applying and enforcing standardized formatting?
There was a problem hiding this comment.
mhhhhh thought it was intentional / agreed... if we're changing the code-style, let's agree on that plus update all the rest. If it's a mistake, just undo the code style refactoring.
There was a problem hiding this comment.
I would rather we do all the reformatting in one PR, otherwise it will pollute PR's going forward. I'm ok getting this merged as is though. Merging now.
tylerbenson
approved these changes
Jul 3, 2017
|
Yes that's fine, we can enforce the code-style with tools and guidelines as you said before. 👍 to me. |
This was referenced May 13, 2025
Merged
Merged
This was referenced May 14, 2025
Closed
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, old file format.
Adding