[SLES-2499] feat: Support sending trace stats via http proxy #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
changed the title
## Overview Collect CPU metric offsets on receiving the PlatformStart instead of the Invoke event to avoid accounting for additional idle time while calculating utilization. Also, guard uptime and idle time to be non-negative for edge-cases. Maintains collecting network offsets on the Invoke event to match with Lambda Insights. ## Testing Tested with self-monitoring <img width="2620" height="904" alt="image" src="https://github.com/user-attachments/assets/6960e9f3-2f35-40d2-9c49-3560e8ebd295" />
https://datadoghq.atlassian.net/browse/SVLS-8005 ## Overview Proxy flush doesn't log the URL in case of error. Need to add it to better investigate the issue. ## Testing n/a
lym953
force-pushed
the
yiming.luo/trace-stats-proxy-2
branch
from
4bc88fd to
68dafbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support sending trace stats to Datadog when the Lambda is in a VPC with a proxy.
Testing
Steps
Result
Before: stats flush failed with error:
After: stats flush was successful.
Dependency
DataDog/libdatadog#1345
Notes
GitHub issue: #860
Jira: https://datadoghq.atlassian.net/browse/SLES-2499