Fix 2031 by revert

[cppcooper]

Fixes #2031 by way of git checkout master -- library/modules/EventManager.cpp then re-adding the new event types.

[myk002]

does this keep the new behavior (freq per handler) for tick events? or is that too complicated to add back without changing the other events too?

[cppcooper]

This keeps the old behaviour. All I did was literally checkout the file from master and add the additional event types. No refactoring was done (aside from renaming the NEW_UNIT_ACTIVE => UNIT_NEW_ACTIVE so that the naming scheme was consistent with the existing UNIT_DEATH)

edit:
Though I think there is an unused when member now.. since I didn't change the header back

[myk002]

Isn't the tick freq configurability required by the spectate plugin? https://github.com/DFHack/dfhack/pull/1918/files#diff-57b4639edbce45b51d81bfb4f7592072c1ebb3e469991755a1b5730b0740179dR67

[cppcooper]

Tick Events use a special queue (unordered_multimap iirc). They calculate when they need to fire and then enqueue with that as the key. I might be getting details wrong but I'm 99% sure that the tick events can be any freq and it'll be obeyed.

The other events in that plugin don't use non-zero frequencies.

#1918 relied on #1876 because of the event types it uses. It needs to look at jobs when they are assigned a worker, not just when they are created. I can see how confusion would arise, I play it a bit loose with my PR contents

[myk002]

ok, cool. understood.

after I merge this, #2044 will be very unhappy. you might want to copy the changed files there somewhere safe, merge current develop (after I merge this PR) and not care about conflicts. Then you can copy your saved files back.