Skip to content

Adds new plugin: Spectate #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 15, 2022
Merged

Adds new plugin: Spectate #1918

merged 8 commits into from
Mar 15, 2022

Conversation

@cppcooper
Copy link
Contributor

@cppcooper cppcooper commented Aug 7, 2021

Relies on PR#1876 - EventManager refactor

Adds a simple plugin for adding a spectate mode

@cppcooper
Copy link
Contributor Author

cppcooper commented Mar 13, 2022

With #1876 merged this can function. If someone could trigger the build checks.

@myk002
Copy link
Member

myk002 commented Mar 13, 2022 •
edited
Loading

Try a
git fetch upstream
And a
git rebase upstream/develop
And a
git push --force

@cppcooper
Copy link
Contributor Author

cppcooper commented Mar 14, 2022

I gave your rebase a try instead of merging.. but it just has too many headaches for the sake of? not having a merge commit? not worth the pain

@cppcooper
Copy link
Contributor Author

cppcooper commented Mar 14, 2022 •
edited
Loading 

 preparing documents... done
writing output... [ 33%] docs/Authors .. docs/NEWS
docs/_auto/news.rst:6: WARNING: undefined label: spectate
writing output... [ 66%] docs/NEWS-dev .. docs/api/Maps
docs/_auto/news-dev.rst:6: WARNING: undefined label: spectate

I suppose this is because it doesn't have a anything in the help docs yet? edit: hmm.. isn't that what the plugins.rst is for?

myk002
myk002 requested changes Mar 14, 2022
View reviewed changes
@cppcooper
Adds requested changes
7fd1e8d 
- foreach syntax replaces active units loops
- removes CR_FAILURE return on double enable/disable usage
- removes disabled code
- implements a few clion clang tidy suggestions (auto declare when casting)
- Updates zcount to have accurate count for performing RNG
- adds eof newline
- adds todo comment about a redundant if condition
@cppcooper
Declares spectate section in Plugins.rst
21c8ccc
@myk002 myk002 merged commit dda487a into DFHack:develop Mar 15, 2022
@cppcooper cppcooper mentioned this pull request Mar 29, 2022
Merged
@cppcooper cppcooper deleted the spectate branch April 19, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myk002 myk002 myk002 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cppcooper @myk002