Skip to content

Removals of EntityList, EntitySequence, JobManager, and Controller #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Removals of EntityList, EntitySequence, JobManager, and Controller #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55bd3e3
first pass removals of entitylist, entitysequence, jobmanager, contro…
juliaputko Sep 5, 2024
82dd5c7
formatting fix
juliaputko Sep 5, 2024
1ca1048
Merge branch 'smartsim-refactor' of https://github.com/CrayLabs/Smart…
juliaputko Sep 9, 2024
2c8ae16
amanda PR review comments
juliaputko Sep 9, 2024
34b559e
update branch
juliaputko Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,8 @@ module = [
# FIXME: DO NOT MERGE THIS INTO DEVELOP BRANCH UNLESS THESE ARE PASSING OR
# REMOVED!!
"smartsim._core._cli.*",
"smartsim._core.control.controller",
"smartsim._core.control.manifest",
"smartsim._core.entrypoints.dragon_client",
"smartsim._core.launcher.colocated",
"smartsim._core.launcher.launcher",
"smartsim._core.launcher.local.*",
"smartsim._core.launcher.lsf.*",
Expand Down
4 changes: 2 additions & 2 deletions smartsim/_core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

from .control import Controller, Manifest, preview_renderer
from .control import Manifest, preview_renderer
from .generation import Generator

__all__ = ["Controller", "Manifest", "Generator", "preview_renderer"]
__all__ = ["Manifest", "Generator", "preview_renderer"]
1 change: 0 additions & 1 deletion smartsim/_core/control/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

from .controller import Controller
from .manifest import Manifest
Loading