Skip to content

Conversation

@juliaputko
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (cce16e6) to head (34b559e).
Report is 13 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/control/manifest.py 42.85% 4 Missing ⚠️
smartsim/_core/utils/telemetry/telemetry.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #693      +/-   ##
=====================================================
+ Coverage              40.45%   46.32%   +5.86%     
=====================================================
  Files                    110      106       -4     
  Lines                   7326     6450     -876     
=====================================================
+ Hits                    2964     2988      +24     
+ Misses                  4362     3462     -900     
Files with missing lines Coverage Δ
smartsim/_core/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/control/__init__.py 100.00% <ø> (ø)
smartsim/_core/control/job.py 30.20% <100.00%> (+1.06%) ⬆️
smartsim/database/orchestrator.py 20.11% <100.00%> (-0.38%) ⬇️
smartsim/entity/__init__.py 100.00% <ø> (ø)
smartsim/_core/utils/telemetry/telemetry.py 25.50% <0.00%> (+0.40%) ⬆️
smartsim/_core/control/manifest.py 48.29% <42.85%> (+1.80%) ⬆️

... and 6 files with indirect coverage changes

Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you go into pyproject.toml and delete the files that you deleted from the list starting at line 150

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliaputko juliaputko merged commit 3bfdff9 into CrayLabs:smartsim-refactor Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants