New develop merger #645
Merged
New develop merger #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Labs#638) Adds the ability to specify hardware affinities for cpu/gpu devices. Creates a dragon policy that uses provided policy to modify the resulting dragon ProcessGroup. [ committed by @ankona ] [ approved by @AlyssaCote @mellis13 @al-rigazzi ]
setup.py used to define dependencies in a way that was not amenable to code scanning tools. Direct dependencies now appear directly in the setup call and the definition of the SmartRedis version has been removed. Additionally, the code scanning tool was failing to detect some of the dependencies due to the existence of the requirements-doc.txt file. These requirements are now listed in the `docs` extra. [ committed by @ashao ] [ reviewed by @ankona ]
This PR addresses an inconstent internal host name representation in the Dragon backend. [ committed by @al-rigazzi ] [ reviewed by @ankona ]
Closed
AlyssaCote
approved these changes
Jul 18, 2024
Contributor
AlyssaCote
left a comment
AlyssaCote
left a comment
There was a problem hiding this comment.
Pending everything passes, LGTM!
ankona
approved these changes
Jul 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #645 +/- ##
==============================================
Coverage ? 66.34%
==============================================
Files ? 97
Lines ? 6760
Branches ? 0
==============================================
Hits ? 4485
Misses ? 2275
Partials ? 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits were not correctly kept in the previous merger.