Fix-hostname #642
Fix-hostname #642
Conversation
| affinity = dragon_policy.Policy.Affinity.SPECIFIC | ||
| gpu_affinity = run_request.policy.gpu_affinity | ||
|
|
||
| logger.debug(f"Affinity: {affinity}, {cpu_affinity}, {gpu_affinity}") |
There was a problem hiding this comment.
If we are going to leave this in, can we clarify the message so we don't rely on remembering the order of the debug output:
logger.debug(f"Affinity: {affinity}")
logger.debug(f"CPU affinity: {cpu_affinity}")
logger.debug(f"GPU affinity: {gpu_affinity}")or do the equivalent in a single line
There was a problem hiding this comment.
Sure, let me do this!
There was a problem hiding this comment.
Per meeting w/dragon team, the affinity parameter is also being dropped and is not used. I should removed affinity and leave only cpu/gpu affinity lists behind. I think that will clear up your ordering comment?
derp. i see that there were no in-message labels. agreed w/your assessment on order
There was a problem hiding this comment.
Agreed they are dropping the affinity parameter. We can still specify CPU and GPU affinity at the same time (and probably want to know which is which) right?
There was a problem hiding this comment.
Yeah, we'll update it as soon as the new version is out.
ankona
left a comment
ankona
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing my bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #642 +/- ##
============================================
+ Coverage 65.44% 77.18% +11.73%
============================================
Files 83 83
Lines 6283 6284 +1
============================================
+ Hits 4112 4850 +738
+ Misses 2171 1434 -737
|
3 participants
This PR addresses an inconstent internal host name representation in the Dragon backend.