Skip to content

Fix-hostname #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Fix-hostname #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68e3f15
Fix inconsistency in internal host representation
al-rigazzi Jul 18, 2024
07c11de
Changelog
al-rigazzi Jul 18, 2024
ec40a3e
Style, lint
al-rigazzi Jul 18, 2024
c6ca057
Improve debug logging
al-rigazzi Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ To be released at some future point in time

Description

- Fix internal host name representation for Dragon backend
- Make dependencies more discoverable in setup.py
- Add hardware pinning capability when using dragon
- Pin NumPy version to 1.x
Expand Down
14 changes: 9 additions & 5 deletions smartsim/_core/launcher/dragon/dragonBackend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ def group_infos(self) -> dict[str, ProcessGroupInfo]:

def _initialize_hosts(self) -> None:
with self._queue_lock:
self._hosts: t.List[str] = sorted(
node for node in dragon_machine.System().nodes
)
self._nodes = [dragon_machine.Node(node) for node in self._hosts]
self._nodes = [
dragon_machine.Node(node) for node in dragon_machine.System().nodes
]
self._hosts: t.List[str] = sorted(node.hostname for node in self._nodes)
self._cpus = [node.num_cpus for node in self._nodes]
self._gpus = [node.num_gpus for node in self._nodes]

Expand Down Expand Up @@ -452,7 +452,11 @@ def create_run_policy(
if run_request.policy.gpu_affinity:
affinity = dragon_policy.Policy.Affinity.SPECIFIC
gpu_affinity = run_request.policy.gpu_affinity

logger.debug(
f"Affinity strategy: {affinity}, "
f"CPU affinity mask: {cpu_affinity}, "
f"GPU affinity mask: {gpu_affinity}"
)
if affinity != dragon_policy.Policy.Affinity.DEFAULT:
return dragon_policy.Policy(
placement=dragon_policy.Policy.Placement.HOST_NAME,
Expand Down