Upgrade to Wasmer 5 and refactor Gatekeeper #2374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aumetra
approved these changes
Feb 7, 2025
webmaster128
changed the title
webmaster128
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2286
While updating wasmer, I decided to change the Gatekeeper to handle whole proposals of operators without having to list all their instructions. Please review that change carefully. The Gatekeeper is somewhat security relevant.
Unfortunately this new wasmer version requires us to bump the CI's min Rust version to 1.81, which is uncomfortably close to 1.82 (which currently doesn't work for compiling contracts unless we merge #2346 or Wasmer implements it)
I also had to fix some stuff in the CI because of the wasmer bump.