Make latitude quadrature points depend on box size #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2022
Codecov Report
@@ Coverage Diff @@
## develop #563 +/- ##
========================================
Coverage 87.16% 87.17%
========================================
Files 108 108
Lines 7979 7984 +5
========================================
+ Hits 6955 6960 +5
Misses 1024 1024
Continue to review full report at Codecov.
|
chris-langfield
previously approved these changes
Feb 15, 2022
In FFBasis3D, this was proportional to `ell_max`, which doesn't make sense. We also loosen tolerances for hardcoded FFB3D tests since these depended on the incorrect reference data and are sensitive to the above change. Eventually, these will be replaced by logical tests (see ComputationalCryoEM#568).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FFBasis3D, this was proportional to
ell_max, which doesn't makesense.
Closes #559.