Skip to content

Remove hardcoded FB tests #568

@janden

Description

@janden

As a result of #563, the tolerances have been loosened for the hardcoded tests. These should ideally go away and be replaced with logical tests (for FB2D, FFB2D, FB3D, and FFB3D):

  1. Check that expandevaluate of a smooth function (e.g., shifted Gaussian) reaches a reasonable tolerance (e.g., 1e-2).
  2. Check that evaluateexpand yields machine precision.
  3. Check that evaluate and evaluate_t satisfy the adjoint property (to machine precision):〈x, A y〉= 〈A* x, y〉, where A is evaluate and A* is evaluate_t.
  4. Isotropic check: radially symmetric images and volumes should only have nonzero coefficients for ell == 0 (optional).

Note that 1–3 should hold for all basis objects, so it may make sense to structure these tests accordingly to reduce code duplication.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions