Skip to content

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Jun 9, 2025

Resolves #1289

Adds pixel size pass-through to ClassAvgSource and DenoisedSource. Also fixes a pixel_size bug in Simulation.

@j-c-c j-c-c self-assigned this Jun 9, 2025
@j-c-c j-c-c added bug Something isn't working cleanup labels Jun 9, 2025
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.61%. Comparing base (9210500) to head (252c28f).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
src/aspire/basis/basis.py 92.85% 2 Missing ⚠️
src/aspire/basis/fspca.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1290   +/-   ##
========================================
  Coverage    90.60%   90.61%           
========================================
  Files          133      133           
  Lines        14348    14373   +25     
========================================
+ Hits         13000    13024   +24     
- Misses        1348     1349    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c
Copy link
Collaborator Author

j-c-c commented Jun 26, 2025

Added pixel_size to the Coef class as discussed in meeting.

@j-c-c j-c-c requested a review from garrettwrong June 26, 2025 18:34
@j-c-c j-c-c marked this pull request as ready for review July 16, 2025 19:32
@j-c-c j-c-c requested a review from janden as a code owner July 16, 2025 19:32
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay.

@j-c-c j-c-c merged commit 1f92a6d into develop Sep 3, 2025
35 checks passed
@j-c-c j-c-c mentioned this pull request Sep 4, 2025
@j-c-c j-c-c mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants