Skip to content

Migrate pixel_size out of filter init #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 24, 2025
Merged

Migrate pixel_size out of filter init #1324

merged 11 commits into from
Sep 24, 2025

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Sep 11, 2025

No description provided.

@garrettwrong garrettwrong self-assigned this Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.61%. Comparing base (7c67fa0) to head (89b7388).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
src/aspire/operators/filters.py 92.85% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1324      +/-   ##
===========================================
- Coverage    90.62%   90.61%   -0.02%     
===========================================
  Files          133      133              
  Lines        14394    14389       -5     
===========================================
- Hits         13044    13038       -6     
- Misses        1350     1351       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong garrettwrong requested a review from j-c-c September 12, 2025 13:39
j-c-c
j-c-c reviewed Sep 12, 2025
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two small things related to the recent pixel size PR that was merged.

@garrettwrong garrettwrong requested a review from j-c-c September 12, 2025 16:51
j-c-c
j-c-c approved these changes Sep 12, 2025
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong garrettwrong marked this pull request as ready for review September 12, 2025 18:41
janden
janden approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. This looks like a lot of work.

All good to me.

@garrettwrong garrettwrong merged commit 04948e6 into develop Sep 24, 2025
36 checks passed
@garrettwrong garrettwrong deleted the pxsz branch September 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

@j-c-c j-c-c j-c-c approved these changes

Assignees

@garrettwrong garrettwrong

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrettwrong @janden @j-c-c