Skip to content

Conversation

@Arlodotexe
Copy link
Member

This PR closes #180, and:

  • Renames the requires parts of the project template so the values are unique for every new experiment.
  • Contains new diagnostics to improve the error message given when the same sample ID is used multiple times
  • Does not contain unit tests. See here for more info.

@Arlodotexe Arlodotexe added dev loop ➰ For issues that impact the core dev-loop of building experiments templating source generator ⚙️ labels Jul 6, 2022
@Arlodotexe Arlodotexe requested a review from michael-hawker July 6, 2022 00:43
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-hawker michael-hawker merged commit 2cd42b2 into main Jul 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/multiple-experiments-from-template-breaks-all-sln-issue180 branch July 6, 2022 01:54
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
…y the project template (CommunityToolkit#185)

* Added safety and diagnostics for detecting duplicate sample ids

* Renamed to prevent name conflicts

* Completed rename to prevent name conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev loop ➰ For issues that impact the core dev-loop of building experiments source generator ⚙️ templating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Having multiple experiments now breaks the "All" solution

2 participants