Skip to content

Fix code completion window visibility issues #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix code completion window visibility issues #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0674a0a
Fix code completion window visibility issues
lucasmotta Sep 29, 2025
515b7a1
Fix remaining canBecomeKeyWindow warnings in BezelNotification
lucasmotta Sep 29, 2025
9332e06
Revert "Fix remaining canBecomeKeyWindow warnings in BezelNotification"
lucasmotta Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/CodeEditSourceEditor/CodeSuggestion/Window/SuggestionController+Window.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ extension SuggestionController {
static func makeWindow() -> NSWindow {
let window = NSWindow(
contentRect: .zero,
styleMask: [.resizable, .fullSizeContentView, .nonactivatingPanel, .utilityWindow],
styleMask: [.borderless],
backing: .buffered,
defer: false
)
Expand All @@ -97,8 +97,10 @@ extension SuggestionController {
window.hasShadow = true
window.isOpaque = false
window.tabbingMode = .disallowed
window.hidesOnDeactivate = true
window.hidesOnDeactivate = false
window.backgroundColor = .clear
window.canHide = false
window.acceptsMouseMovedEvents = true

return window
}
Expand Down
11 changes: 9 additions & 2 deletions Sources/CodeEditSourceEditor/CodeSuggestion/Window/SuggestionController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ public final class SuggestionController: NSWindowController {
/// Opens the window as a child of another window.
public func showWindow(attachedTo parentWindow: NSWindow) {
guard let window = window else { return }

super.showWindow(nil)
parentWindow.addChildWindow(window, ordered: .above)
window.orderFront(nil)

// Close on window switch observer
// Initialized outside of `setupEventMonitors` in order to grab the parent window
Expand All @@ -118,8 +121,6 @@ public final class SuggestionController: NSWindowController {
self?.close()
}

super.showWindow(nil)
window.orderFront(nil)
window.contentViewController?.viewWillAppear()
}

Expand All @@ -134,6 +135,12 @@ public final class SuggestionController: NSWindowController {
contentViewController?.viewWillDisappear()
}

// Clean up window observers
if let observer = windowResignObserver {
NotificationCenter.default.removeObserver(observer)
windowResignObserver = nil
}

super.close()
}

Expand Down