Fix code completion window visibility issues #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves intermittent visibility problems where the code completion window would not appear visually despite functioning correctly for keyboard navigation. Changes: - Replace problematic window style masks (.nonactivatingPanel, .utilityWindow) with .borderless - Set hidesOnDeactivate to false to prevent unexpected hiding - Add canHide = false and acceptsMouseMovedEvents = true for better window behavior - Improve window showing sequence in showWindow(attachedTo:) - Add proper cleanup of notification observers in close() The .nonactivatingPanel style was preventing the window from becoming key, causing the "canBecomeKeyWindow returned NO" warning and inconsistent visibility. Using .borderless provides the clean appearance needed for code completion while ensuring reliable display. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Removes .nonactivatingPanel from BezelNotification window style mask to eliminate console warnings while maintaining non-activating behavior through .hudWindow style. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This reverts commit 515b7a1.
|
I haven't had a chance to play with this yet but we do want to allow the user to resize the window horizontally. Can we make sure that's still happening after removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CleanShot.2025-09-29.at.19.15.38.mp4
Fixes intermittent visibility problems where the code completion window would not appear visually despite functioning correctly for keyboard navigation.
Fixes #351
Changes Made
.nonactivatingPaneland.utilityWindowwith.borderlesshidesOnDeactivatefromtruetofalsecanHide = falseandacceptsMouseMovedEvents = trueshowWindow(attachedTo:)close()Root Cause
The
.nonactivatingPanelstyle mask was preventing the window from becoming key, which caused:canBecomeKeyWindow returned NOSolution
Using
.borderlessprovides the clean appearance needed for code completion while ensuring reliable window display. This style mask is ideal for popover-style UI elements as it gives full control over positioning and appearance without the activation issues.Test Plan
canBecomeKeyWindowconsole warnings🤖 Generated with Claude Code