Change method visibility #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Would be great if you also make the PRs for v2.0. Thanks a lot ! |
CodeDredd
pushed a commit
that referenced
this pull request
Feb 26, 2021
CodeDredd
added a commit
that referenced
this pull request
Feb 26, 2021
* Make basic auth configurable via config (#105) Solves #103 * Change method visibility (#106) * chore(2.0): Take change form 1.0 - drafter, tests & PRs from @chiya. * refactor(2.0): Change php version for tests to 8.0. Co-authored-by: Elisha Witte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / Use Case
In our system, some configuration options (e.g. basic auth credentials) are encrypted. I need to be able to extend the
SoapClientwith my own method for bootstrapping the client at runtime (similar tobuildClient). Some methods are declared asprivate, preventing this.Again, I need this on the v1.x branch, but I can create a PR for v2 as well if this gets merged.