Make basic auth configurable via config #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeDredd
approved these changes
Feb 26, 2021
Owner
CodeDredd
left a comment
CodeDredd
left a comment
There was a problem hiding this comment.
Looks good to me. I try to add a unit test to it.
Contributor
Author
|
Thanks for merging! I tried setting up a unit test but couldn't figure out how to check if the middleware was applied correctly. |
CodeDredd
added a commit
that referenced
this pull request
Feb 26, 2021
* Make basic auth configurable via config (#105) Solves #103 * Change method visibility (#106) * chore(2.0): Take change form 1.0 - drafter, tests & PRs from @chiya. * refactor(2.0): Change php version for tests to 8.0. Co-authored-by: Elisha Witte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #103
I can create a PR for v2 as well if this solution is fine for you.