Paper -> Count Route #219
Open
Paper -> Count Route #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new component to display users starred papers
|
make a note to put a button that redirects to the page for adding new papers incase there isn't one in the design |
abhitrueprogrammer
requested changes
Jun 17, 2025
src/components/PapersCarousel.tsx
Outdated
| function PapersCarousel({ | ||
| carouselType, | ||
| }: { | ||
| carouselType: "users" | "default"; |
There was a problem hiding this comment.
Nice work in here, just change it to upcoming and users and make the default as upcoming using carouselType="default"
RustyDev24
reviewed
Jul 18, 2025
Comment on lines
+11
to
+12
| const { searchParams } = new URL(req.url); | ||
| const subject = searchParams.get("subject"); |
There was a problem hiding this comment.
req.query.subject should work
| { status: 200 } | ||
| ); | ||
| const filter = subject ? { subject } : {}; | ||
| const count = await Paper.countDocuments(filter); |
There was a problem hiding this comment.
why not just maintain a counter in db
and increment those values on the fly
| @@ -29,7 +29,7 @@ export async function GET(req: NextRequest) { | |||
| if (papers.length === 0) { | |||
| return NextResponse.json( | |||
| { message: "No papers found for the specified subject" }, | |||
| { status: 404 }, | |||
| { status: 200 }, | |||
There was a problem hiding this comment.
errors shouldn't be 200
|
|
||
| export async function POST(req: Request) { | ||
| try { | ||
| await connectToDatabase(); |
There was a problem hiding this comment.
this will happen at startup u dont need to do this
| await connectToDatabase(); | ||
| const body = (await req.json()) as StoredSubjects; | ||
|
|
||
| const subjects = body; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made paper count route in api