Created new component to display users starred papers #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/api/user-papers/route.ts
Outdated
Comment on lines
18
to
21
| let transformedPapers = usersPapers.map((paper) => ({ | ||
| subject: paper.subject, | ||
| slots: [paper.slot], | ||
| })); |
There was a problem hiding this comment.
a single paper can have multiple slots right
src/app/api/user-papers/route.ts
Outdated
Comment on lines
24
to
26
| transformedPapers = Array.from( | ||
| new Map(transformedPapers.map((item) => [item.subject, item])).values(), | ||
| ); |
There was a problem hiding this comment.
rather interesting way of checking duplicates
| }); | ||
| return response.data.papers.length; // Assuming the API returns an array of papers | ||
| } catch (error) { | ||
| return 0; // Return 0 if there's no papers found or an error occurs |
There was a problem hiding this comment.
the state that notifies of an error and the state that means 0 papers found should be different. Preferably the error should be printed or toasted
Comment on lines
23
to
33
| const fetchPaperQuantityByName = async (subjectName: string) => { | ||
| try { | ||
| const response = await axios.get("/api/papers", { | ||
| params: { subject: subjectName }, | ||
| }); | ||
| return response.data.papers.length; // Assuming the API returns an array of papers | ||
| } catch (error) { | ||
| return 0; // Return 0 if there's no papers found or an error occurs | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Is this function being used somewhere?
src/components/UsersPapers.tsx
Outdated
There was a problem hiding this comment.
Since we are gonna change it later we'll let this copy paste slider, otherwise making a simple template and then using it in both the upcoming papers and user Paper components would have been better. See if you can refactor it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.