Returns ObserverAI to working order #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dysonreturns
commented
Jun 26, 2025
dysonreturns
commented
- The example observer file needs it's path to be cast to string, otherwise we get a TypeError.
- ObserverAI dependend on deprecated self._client, self._game_data, self._game_info fields. They shoudl now be accessed directly.
- Additionally, observing as Everyone (player 0) broke, because it had no race. When player is 0, we assign the race of Random and it has no concerns.
added 5 commits
January 17, 2025 12:32
…are based on. Latest 5.0.14 (94137) is bugged on the API, i.e. missing a lot of Upgrades. This commit allows sc2-techtree to this version, by supplying `run_game` with: `, sc2_version="5.0.14.93333")`
…andom Race for player_id 0(zero)
Owner
|
Thanks for putting effort into it. I would like to add at least one test case, too. Because otherwise the Can you think of a (simple) strategy to test it? Will a real bot replay be needed? Perhaps one can be created during the test, and then run through the |
…renzy Add abilities with empty 'buttonname' in stableid.json
…perty Makes unit.tag be @cached_property
…ield Adds `ActionObserverCameraMove.distance` enabling wide zoom-out
…urns/python-sc2 into dysonreturns-old-launcher-accept-sc2_version
…-sc2_version Allow passing in sc2_version to all legacy host and launch methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.