Makes unit.tag be @cached_property #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an optimization.
I ran cProfiler on an example bot of sorts and noticed that
unit.tagis one of the worst offenders.I made it a cached property instead and it cleared itself up.
This is due to heavy dictionary lookups in practice.
Rasper has been manually caching tag in his framework for some time, using custom overrides and agrees this change is safe.
So, nowhere in the library or in the wild do we manually change a unit's identifier once set.
I firmly believe this can go upstream.
Before:
After:
